Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2546333002: Changed Order to an enum class and renamed its members (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 6f80b12fb2b7392860d9d47cd03552cf13daef49..1d634bd9b92df30c231eda7952b8bede9a55480a 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -3546,28 +3546,28 @@ inline CSSIdentifierValue::CSSIdentifierValue(ESpeak e)
}
template <>
-inline Order CSSIdentifierValue::convertTo() const {
+inline EOrder CSSIdentifierValue::convertTo() const {
switch (m_valueID) {
case CSSValueLogical:
- return LogicalOrder;
+ return EOrder::Logical;
case CSSValueVisual:
- return VisualOrder;
+ return EOrder::Visual;
default:
napper 2016/12/05 02:18:22 I realize this is not part of your CL but this lin
sashab 2016/12/05 02:41:18 The reason it's there I think is otherwise you get
break;
}
ASSERT_NOT_REACHED();
- return LogicalOrder;
+ return EOrder::Logical;
}
template <>
-inline CSSIdentifierValue::CSSIdentifierValue(Order e)
+inline CSSIdentifierValue::CSSIdentifierValue(EOrder e)
: CSSValue(IdentifierClass) {
switch (e) {
- case LogicalOrder:
+ case EOrder::Logical:
m_valueID = CSSValueLogical;
break;
- case VisualOrder:
+ case EOrder::Visual:
m_valueID = CSSValueVisual;
break;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698