Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2546063002: Rename FormAssociatedElement to ListedElement (Closed)

Created:
4 years ago by yurak
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dominicc (has gone to gerrit), gavinp+loader_chromium.org, haraken, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename FormAssociatedElement to ListedElement. Planning on adding a new interface for form association code called FormAssociated.h so I'm renaming this to avoid confusion. BUG=672359 Committed: https://crrev.com/4ed88b2834497778b8a4e8d73334c0e83cd8307d Cr-Commit-Position: refs/heads/master@{#436222}

Patch Set 1 #

Patch Set 2 : Rename FormAssociatedElement to ListedElement #

Total comments: 18

Patch Set 3 : Suggested changes made #

Patch Set 4 : Rebased #

Total comments: 2

Patch Set 5 : Suggested changes made #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -685 lines) Patch
M third_party/WebKit/Source/core/html/BUILD.gn View 1 2 2 chunks +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/html/FormAssociatedElement.h View 1 chunk +0 lines, -134 lines 0 comments Download
D third_party/WebKit/Source/core/html/FormAssociatedElement.cpp View 1 chunk +0 lines, -329 lines 0 comments Download
M third_party/WebKit/Source/core/html/FormData.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlsCollection.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp View 1 2 3 4 6 chunks +23 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.h View 1 2 3 4 6 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 2 3 4 15 chunks +48 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.h View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/html/ListedElement.h View 1 4 chunks +12 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/core/html/ListedElement.cpp View 1 2 9 chunks +58 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/core/html/ValidityState.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FormSubmission.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFormElement.cpp View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebSearchableFormData.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
yurak
PTL
4 years ago (2016-12-02 09:34:42 UTC) #3
tkent
https://codereview.chromium.org/2546063002/diff/20001/third_party/WebKit/Source/core/html/BUILD.gn File third_party/WebKit/Source/core/html/BUILD.gn (right): https://codereview.chromium.org/2546063002/diff/20001/third_party/WebKit/Source/core/html/BUILD.gn#newcode222 third_party/WebKit/Source/core/html/BUILD.gn:222: "ListedElement.cpp", Add ListedElement.h too. https://codereview.chromium.org/2546063002/diff/20001/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h File third_party/WebKit/Source/core/html/HTMLFieldSetElement.h (right): https://codereview.chromium.org/2546063002/diff/20001/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h#newcode44 ...
4 years ago (2016-12-02 13:24:37 UTC) #4
yurak
Made suggested changes. PTL.
4 years ago (2016-12-03 12:40:29 UTC) #5
tkent
https://codereview.chromium.org/2546063002/diff/60001/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.h File third_party/WebKit/Source/core/html/HTMLFormControlsCollection.h (right): https://codereview.chromium.org/2546063002/diff/60001/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.h#newcode64 third_party/WebKit/Source/core/html/HTMLFormControlsCollection.h:64: const ListedElement::List& formListedElements() const; formListedElement() -> listedElement() https://codereview.chromium.org/2546063002/diff/60001/third_party/WebKit/Source/core/html/HTMLFormElement.h File ...
4 years ago (2016-12-04 12:57:10 UTC) #6
yurak
On 2016/12/04 at 12:57:10, tkent wrote: > https://codereview.chromium.org/2546063002/diff/60001/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.h > File third_party/WebKit/Source/core/html/HTMLFormControlsCollection.h (right): > > https://codereview.chromium.org/2546063002/diff/60001/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.h#newcode64 ...
4 years ago (2016-12-05 01:19:37 UTC) #7
tkent
lgtm
4 years ago (2016-12-05 01:25:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546063002/80001
4 years ago (2016-12-05 01:25:42 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-05 03:15:01 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-05 03:16:58 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/4ed88b2834497778b8a4e8d73334c0e83cd8307d
Cr-Commit-Position: refs/heads/master@{#436222}

Powered by Google App Engine
This is Rietveld 408576698