Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2544893006: Revert of Reland "Fix HTML5 video blurry" (Closed)

Created:
4 years ago by ynovikov
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, miu+watch_chromium.org, krit, drott+blinkwatch_chromium.org, jam, Justin Novosad, jbauman+watch_chromium.org, posciak+watch_chromium.org, Rik, darin-cc_chromium.org, blink-reviews, einbinder+watch-test-runner_chromium.org, xjz+watch_chromium.org, rwlbuis, ajuma+watch_chromium.org, jbroman, feature-media-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, ajuma+watch-canvas_chromium.org, f(malita), cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland "Fix HTML5 video blurry" (patchset #3 id:40001 of https://codereview.chromium.org/2547683003/ ) Reason for revert: I suspect this breaks https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28AMD%29/builds/565 Error compiling shader: ERROR: 0:7: '[]' : Index expression must be constant Original issue's description: > Reland "Fix HTML5 video blurry" > > Original CL: https://codereview.chromium.org/2418173002/ > > Revert CL: https://codereview.chromium.org/2463103002/ > https://codereview.chromium.org/2474073004 > > Changes: Skip failed gpu pixel tests until baseline is created. > Fix following failures in Win7 dbg > RendererPixelTest/2.PremultipliedTextureWithBackground > GLRendererPixelTest.TextureQuadBatching > RendererPixelTest/0.PremultipliedTextureWithBackground > GLRendererPixelTest.NonPremultipliedTextureWithBackground > IntersectingQuadGLPixelTest/0.Y16VideoQuads > VideoGLRendererPixelTest.TwoColorY16Rect > IntersectingQuadGLPixelTest/1.Y16VideoQuads > > TBR=dalecurtis@chromium.org,ccameron@chromium.org,dpranke@chromium.org,junov@chromium.org > BUG=615325 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Committed: https://crrev.com/60d375f8a6bd7b8c3e3abfd3771a228f3039bf62 > Cr-Commit-Position: refs/heads/master@{#436118} TBR=ccameron@chromium.org,dalecurtis@chromium.org,dpranke@chromium.org,enne@chromium.org,junov@chromium.org,dongseong.hwang@chromium.org,dongseong.hwang@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615325 Committed: https://crrev.com/6c406fd0ca401c34de9a9335bad24fc9435a2037 Cr-Commit-Position: refs/heads/master@{#436176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -652 lines) Patch
M cc/layers/video_layer_impl.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M cc/output/gl_renderer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M cc/output/gl_renderer.cc View 7 chunks +2 lines, -52 lines 0 comments Download
M cc/output/gl_renderer_draw_cache.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 15 chunks +79 lines, -203 lines 0 comments Download
M cc/output/shader.h View 1 chunk +76 lines, -105 lines 0 comments Download
M cc/output/shader.cc View 5 chunks +49 lines, -102 lines 0 comments Download
M cc/resources/resource_provider.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M cc/resources/video_resource_updater.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 7 chunks +19 lines, -45 lines 0 comments Download
M cc/test/data/yuv_stripes.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_alpha.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_clipped.png View Binary file 0 comments Download
D cc/test/data/yuv_stripes_clipped_rgba.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_offset.png View Binary file 0 comments Download
D cc/test/data/yuv_stripes_rgba.png View Binary file 0 comments Download
M cc/test/render_pass_test_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/test_in_process_context_provider.h View 2 chunks +0 lines, -10 lines 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +0 lines, -14 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_test_pages.py View 3 chunks +7 lines, -7 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 5 chunks +60 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
ynovikov
Created Revert of Reland "Fix HTML5 video blurry"
4 years ago (2016-12-03 04:41:13 UTC) #1
ynovikov
I need a committer to lgtm this
4 years ago (2016-12-03 04:43:30 UTC) #3
ynovikov
Also breaks https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Release%20%28NVIDIA%29/builds/8246
4 years ago (2016-12-03 04:53:26 UTC) #4
ynovikov
On 2016/12/03 04:53:26, ynovikov wrote: > Also breaks > https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Release%20%28NVIDIA%29/builds/8246 I also suspect this for ...
4 years ago (2016-12-03 05:06:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544893006/1
4 years ago (2016-12-03 05:07:16 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-03 05:07:18 UTC) #9
aleksandar.stojiljkovic
On 2016/12/03 04:43:30, ynovikov wrote: > I need a committer to lgtm this This should ...
4 years ago (2016-12-03 18:12:47 UTC) #11
Ken Russell (switch to Gerrit)
lgtm
4 years ago (2016-12-03 22:23:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544893006/1
4 years ago (2016-12-03 22:23:53 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 22:25:13 UTC) #17
Ken Russell (switch to Gerrit)
On 2016/12/03 04:43:30, ynovikov wrote: > I need a committer to lgtm this I'm sorry ...
4 years ago (2016-12-03 22:26:53 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-03 22:26:54 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c406fd0ca401c34de9a9335bad24fc9435a2037
Cr-Commit-Position: refs/heads/master@{#436176}

Powered by Google App Engine
This is Rietveld 408576698