Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2474073004: Revert of Reland "Fix HTML5 video blurry" (Closed)

Created:
4 years, 1 month ago by Mike West
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, miu+watch_chromium.org, krit, drott+blinkwatch_chromium.org, jam, Justin Novosad, jbauman+watch_chromium.org, posciak+watch_chromium.org, Rik, darin-cc_chromium.org, blink-reviews, einbinder+watch-test-runner_chromium.org, xjz+watch_chromium.org, rwlbuis, ajuma+watch_chromium.org, jbroman, feature-media-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, ajuma+watch-canvas_chromium.org, f(malita), cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland "Fix HTML5 video blurry" (patchset #6 id:120001 of https://codereview.chromium.org/2461423002/ ) Reason for revert: cc_unittests on Windows-7-SP1 failing on chromium.win/Win7 Tests (dbg)(1): RendererPixelTest/2.PremultipliedTextureWithBackground GLRendererPixelTest.TextureQuadBatching RendererPixelTest/0.PremultipliedTextureWithBackground GLRendererPixelTest.NonPremultipliedTextureWithBackground IntersectingQuadGLPixelTest/0.Y16VideoQuads VideoGLRendererPixelTest.TwoColorY16Rect IntersectingQuadGLPixelTest/1.Y16VideoQuads https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54356 is the first fail Looks like this reland is the culprit. BUG=662385 Original issue's description: > Reland "Fix HTML5 video blurry" > > Original CL: https://codereview.chromium.org/2418173002/ > > Revert CL: https://codereview.chromium.org/2463103002/ > > Changes: Skip failed gpu pixel tests until baseline is created. > > TBR=dalecurtis@chromium.org,ccameron@chromium.org,dpranke@chromium.org,enne@chromium.org,junov@chromium.org > BUG=615325 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/4bfcc05d589ea7c232c4e207380135c1cf28e3d7 > Cr-Commit-Position: refs/heads/master@{#429849} TBR=dongseong.hwang@chromium.org,enne@chromium.org,kbr@chromium.org,aleksandar.stojiljkovic@intel.com,dongseong.hwang@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615325 Committed: https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73 Cr-Commit-Position: refs/heads/master@{#429866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -650 lines) Patch
M cc/layers/video_layer_impl.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M cc/output/gl_renderer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M cc/output/gl_renderer.cc View 7 chunks +2 lines, -50 lines 0 comments Download
M cc/output/gl_renderer_draw_cache.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 15 chunks +79 lines, -203 lines 0 comments Download
M cc/output/shader.h View 1 chunk +76 lines, -105 lines 0 comments Download
M cc/output/shader.cc View 5 chunks +49 lines, -102 lines 0 comments Download
M cc/resources/resource_provider.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M cc/resources/video_resource_updater.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 7 chunks +19 lines, -45 lines 0 comments Download
M cc/test/data/yuv_stripes.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_alpha.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_clipped.png View Binary file 0 comments Download
D cc/test/data/yuv_stripes_clipped_rgba.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_offset.png View Binary file 0 comments Download
D cc/test/data/yuv_stripes_rgba.png View Binary file 0 comments Download
M cc/test/render_pass_test_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/test_in_process_context_provider.h View 2 chunks +0 lines, -10 lines 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +0 lines, -14 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_test_pages.py View 3 chunks +7 lines, -7 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 5 chunks +60 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
Created Revert of Reland "Fix HTML5 video blurry"
4 years, 1 month ago (2016-11-04 12:44:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474073004/1
4 years, 1 month ago (2016-11-04 12:45:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 12:46:34 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 12:48:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73
Cr-Commit-Position: refs/heads/master@{#429866}

Powered by Google App Engine
This is Rietveld 408576698