Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2463103002: Revert of Fix HTML5 video blurry (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
CC:
cc-bugs_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix HTML5 video blurry (patchset #8 id:220001 of https://codereview.chromium.org/2418173002/ ) Reason for revert: Suspect causing cc_unittests failure: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54203 Original issue's description: > Fix HTML5 video blurry > > HW decoded video is blurry, because crbug.com/575587 shinked visual rect by 1 > pixel, if coded rect is larger than visual rect. This fixed bleeding texture, > but caused blurry issue. > > Meanwhile, crbug.com/429640 fixed bleeding texture for software YUV video in > the elegant way. It clamps all texture coordinates to this maximum value in the > fragment shader. > > This CL removes the 1 pixel hack and applies the way to TextureDrawQuad and > StreamVideoDrawQuad (i.e. HW decoded video path). > > BUG=615325 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/b38566a76c4af61c0d34df7d8b906e7936b8e524 > Cr-Commit-Position: refs/heads/master@{#428707} TBR=dalecurtis@chromium.org,ccameron@chromium.org,dongseong.hwang@chromium.org,dpranke@chromium.org,enne@chromium.org,junov@chromium.org,dongseong.hwang@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615325 Committed: https://crrev.com/dbe5eeec015f378c72815d67e6b379e197168a91 Cr-Commit-Position: refs/heads/master@{#428735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -606 lines) Patch
M cc/layers/video_layer_impl.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M cc/output/gl_renderer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M cc/output/gl_renderer.cc View 7 chunks +2 lines, -50 lines 0 comments Download
M cc/output/gl_renderer_draw_cache.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 14 chunks +78 lines, -201 lines 0 comments Download
M cc/output/shader.h View 1 chunk +76 lines, -105 lines 0 comments Download
M cc/output/shader.cc View 5 chunks +49 lines, -102 lines 0 comments Download
M cc/resources/resource_provider.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 6 chunks +11 lines, -34 lines 0 comments Download
M cc/test/data/yuv_stripes.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_alpha.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_clipped.png View Binary file 0 comments Download
D cc/test/data/yuv_stripes_clipped_rgba.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_offset.png View Binary file 0 comments Download
D cc/test/data/yuv_stripes_rgba.png View Binary file 0 comments Download
M cc/test/render_pass_test_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/test_in_process_context_provider.h View 2 chunks +0 lines, -10 lines 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 4 chunks +56 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xidachen
Created Revert of Fix HTML5 video blurry
4 years, 1 month ago (2016-10-31 16:26:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463103002/1
4 years, 1 month ago (2016-10-31 16:26:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 16:27:40 UTC) #5
Dirk Pranke
lgtm
4 years, 1 month ago (2016-10-31 16:33:37 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 16:45:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbe5eeec015f378c72815d67e6b379e197168a91
Cr-Commit-Position: refs/heads/master@{#428735}

Powered by Google App Engine
This is Rietveld 408576698