Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Side by Side Diff: cc/output/renderer_pixeltest.cc

Issue 2544893006: Revert of Reland "Fix HTML5 video blurry" (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/output/gl_renderer_draw_cache.h ('k') | cc/output/shader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/string_split.h"
11 #include "cc/base/math_util.h" 10 #include "cc/base/math_util.h"
12 #include "cc/output/gl_renderer.h" 11 #include "cc/output/gl_renderer.h"
13 #include "cc/quads/draw_quad.h" 12 #include "cc/quads/draw_quad.h"
14 #include "cc/quads/picture_draw_quad.h" 13 #include "cc/quads/picture_draw_quad.h"
15 #include "cc/quads/texture_draw_quad.h" 14 #include "cc/quads/texture_draw_quad.h"
16 #include "cc/resources/video_resource_updater.h" 15 #include "cc/resources/video_resource_updater.h"
17 #include "cc/test/fake_raster_source.h" 16 #include "cc/test/fake_raster_source.h"
18 #include "cc/test/fake_recording_source.h" 17 #include "cc/test/fake_recording_source.h"
19 #include "cc/test/pixel_test.h" 18 #include "cc/test/pixel_test.h"
20 #include "cc/test/test_in_process_context_provider.h"
21 #include "gpu/command_buffer/client/gles2_interface.h" 19 #include "gpu/command_buffer/client/gles2_interface.h"
22 #include "media/base/video_frame.h" 20 #include "media/base/video_frame.h"
23 #include "third_party/skia/include/core/SkColorPriv.h" 21 #include "third_party/skia/include/core/SkColorPriv.h"
24 #include "third_party/skia/include/core/SkImageFilter.h" 22 #include "third_party/skia/include/core/SkImageFilter.h"
25 #include "third_party/skia/include/core/SkMatrix.h" 23 #include "third_party/skia/include/core/SkMatrix.h"
26 #include "third_party/skia/include/core/SkRefCnt.h" 24 #include "third_party/skia/include/core/SkRefCnt.h"
27 #include "third_party/skia/include/core/SkSurface.h" 25 #include "third_party/skia/include/core/SkSurface.h"
28 #include "third_party/skia/include/effects/SkColorFilterImageFilter.h" 26 #include "third_party/skia/include/effects/SkColorFilterImageFilter.h"
29 #include "third_party/skia/include/effects/SkColorMatrixFilter.h" 27 #include "third_party/skia/include/effects/SkColorMatrixFilter.h"
30 #include "ui/gfx/geometry/rect_conversions.h" 28 #include "ui/gfx/geometry/rect_conversions.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 gfx::ColorSpace video_color_space = video_frame->ColorSpace(); 210 gfx::ColorSpace video_color_space = video_frame->ColorSpace();
213 211
214 const gfx::Rect opaque_rect(0, 0, 0, 0); 212 const gfx::Rect opaque_rect(0, 0, 0, 0);
215 213
216 if (with_alpha) { 214 if (with_alpha) {
217 memset(video_frame->data(media::VideoFrame::kAPlane), alpha_value, 215 memset(video_frame->data(media::VideoFrame::kAPlane), alpha_value,
218 video_frame->stride(media::VideoFrame::kAPlane) * 216 video_frame->stride(media::VideoFrame::kAPlane) *
219 video_frame->rows(media::VideoFrame::kAPlane)); 217 video_frame->rows(media::VideoFrame::kAPlane));
220 } 218 }
221 219
222 VideoFrameExternalResources external_resources = 220 VideoFrameExternalResources resources =
223 video_resource_updater->CreateExternalResourcesFromVideoFrame( 221 video_resource_updater->CreateExternalResourcesFromVideoFrame(
224 video_frame); 222 video_frame);
225 223
226 ResourceProvider::ResourceIdArray resource_ids; 224 EXPECT_EQ(VideoFrameExternalResources::YUV_RESOURCE, resources.type);
227 resource_ids.reserve(external_resources.mailboxes.size()); 225 EXPECT_EQ(media::VideoFrame::NumPlanes(video_frame->format()),
228 for (size_t i = 0; i < external_resources.mailboxes.size(); ++i) { 226 resources.mailboxes.size());
229 ResourceId resource_id = 227 EXPECT_EQ(media::VideoFrame::NumPlanes(video_frame->format()),
230 resource_provider->CreateResourceFromTextureMailbox( 228 resources.release_callbacks.size());
231 external_resources.mailboxes[i], 229
232 SingleReleaseCallbackImpl::Create( 230 ResourceId y_resource = resource_provider->CreateResourceFromTextureMailbox(
233 external_resources.release_callbacks[i]), 231 resources.mailboxes[media::VideoFrame::kYPlane],
234 external_resources.read_lock_fences_enabled); 232 SingleReleaseCallbackImpl::Create(
235 resource_ids.push_back(resource_id); 233 resources.release_callbacks[media::VideoFrame::kYPlane]));
234 ResourceId u_resource = resource_provider->CreateResourceFromTextureMailbox(
235 resources.mailboxes[media::VideoFrame::kUPlane],
236 SingleReleaseCallbackImpl::Create(
237 resources.release_callbacks[media::VideoFrame::kUPlane]));
238 ResourceId v_resource = resource_provider->CreateResourceFromTextureMailbox(
239 resources.mailboxes[media::VideoFrame::kVPlane],
240 SingleReleaseCallbackImpl::Create(
241 resources.release_callbacks[media::VideoFrame::kVPlane]));
242 ResourceId a_resource = 0;
243 if (with_alpha) {
244 a_resource = resource_provider->CreateResourceFromTextureMailbox(
245 resources.mailboxes[media::VideoFrame::kAPlane],
246 SingleReleaseCallbackImpl::Create(
247 resources.release_callbacks[media::VideoFrame::kAPlane]));
236 } 248 }
237 249
238 switch (external_resources.type) { 250 const gfx::Size ya_tex_size = video_frame->coded_size();
239 case VideoFrameExternalResources::YUV_RESOURCE: { 251 const gfx::Size uv_tex_size = media::VideoFrame::PlaneSize(
240 EXPECT_EQ(media::VideoFrame::NumPlanes(video_frame->format()), 252 video_frame->format(), media::VideoFrame::kUPlane,
241 external_resources.mailboxes.size()); 253 video_frame->coded_size());
242 EXPECT_EQ(media::VideoFrame::NumPlanes(video_frame->format()), 254 DCHECK(uv_tex_size == media::VideoFrame::PlaneSize(
243 external_resources.release_callbacks.size()); 255 video_frame->format(), media::VideoFrame::kVPlane,
244 const gfx::Size ya_tex_size = video_frame->coded_size(); 256 video_frame->coded_size()));
245 const gfx::Size uv_tex_size = media::VideoFrame::PlaneSize( 257 if (with_alpha) {
246 video_frame->format(), media::VideoFrame::kUPlane, 258 DCHECK(ya_tex_size == media::VideoFrame::PlaneSize(
247 video_frame->coded_size()); 259 video_frame->format(), media::VideoFrame::kAPlane,
248 DCHECK(uv_tex_size == 260 video_frame->coded_size()));
249 media::VideoFrame::PlaneSize(video_frame->format(), 261 }
250 media::VideoFrame::kVPlane,
251 video_frame->coded_size()));
252 if (with_alpha) {
253 DCHECK(ya_tex_size ==
254 media::VideoFrame::PlaneSize(video_frame->format(),
255 media::VideoFrame::kAPlane,
256 video_frame->coded_size()));
257 }
258 gfx::RectF ya_tex_coord_rect(
259 tex_coord_rect.x() * ya_tex_size.width(),
260 tex_coord_rect.y() * ya_tex_size.height(),
261 tex_coord_rect.width() * ya_tex_size.width(),
262 tex_coord_rect.height() * ya_tex_size.height());
263 gfx::RectF uv_tex_coord_rect(
264 tex_coord_rect.x() * uv_tex_size.width(),
265 tex_coord_rect.y() * uv_tex_size.height(),
266 tex_coord_rect.width() * uv_tex_size.width(),
267 tex_coord_rect.height() * uv_tex_size.height());
268 262
269 YUVVideoDrawQuad* yuv_quad = 263 gfx::RectF ya_tex_coord_rect(tex_coord_rect.x() * ya_tex_size.width(),
270 render_pass->CreateAndAppendDrawQuad<YUVVideoDrawQuad>(); 264 tex_coord_rect.y() * ya_tex_size.height(),
271 yuv_quad->SetNew( 265 tex_coord_rect.width() * ya_tex_size.width(),
272 shared_state, rect, opaque_rect, visible_rect, ya_tex_coord_rect, 266 tex_coord_rect.height() * ya_tex_size.height());
273 uv_tex_coord_rect, ya_tex_size, uv_tex_size, resource_ids[0], 267 gfx::RectF uv_tex_coord_rect(tex_coord_rect.x() * uv_tex_size.width(),
274 resource_ids[1], 268 tex_coord_rect.y() * uv_tex_size.height(),
275 resource_ids.size() > 2 ? resource_ids[2] : resource_ids[1], 269 tex_coord_rect.width() * uv_tex_size.width(),
276 resource_ids.size() > 3 ? resource_ids[3] : 0, color_space, 270 tex_coord_rect.height() * uv_tex_size.height());
277 video_color_space, external_resources.offset, 271
278 external_resources.multiplier, external_resources.bits_per_channel); 272 YUVVideoDrawQuad* yuv_quad =
279 break; 273 render_pass->CreateAndAppendDrawQuad<YUVVideoDrawQuad>();
280 } 274 uint32_t bits_per_channel = 8;
281 case VideoFrameExternalResources::RGBA_RESOURCE: { 275 if (video_frame->format() == media::PIXEL_FORMAT_YUV420P10 ||
282 EXPECT_EQ(1u, external_resources.mailboxes.size()); 276 video_frame->format() == media::PIXEL_FORMAT_YUV422P10 ||
283 EXPECT_EQ(1u, external_resources.release_callbacks.size()); 277 video_frame->format() == media::PIXEL_FORMAT_YUV444P10) {
284 float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f}; 278 bits_per_channel = 10;
285 TextureDrawQuad* texture_quad =
286 render_pass->CreateAndAppendDrawQuad<TextureDrawQuad>();
287 texture_quad->SetNew(shared_state, rect, opaque_rect, visible_rect,
288 resource_ids[0], false, tex_coord_rect.origin(),
289 tex_coord_rect.bottom_right(), SK_ColorTRANSPARENT,
290 opacity, false, false, false);
291 break;
292 }
293 case VideoFrameExternalResources::NONE:
294 case VideoFrameExternalResources::RGB_RESOURCE:
295 case VideoFrameExternalResources::RGBA_PREMULTIPLIED_RESOURCE:
296 case VideoFrameExternalResources::STREAM_TEXTURE_RESOURCE:
297 case VideoFrameExternalResources::SOFTWARE_RESOURCE:
298 NOTREACHED();
299 break;
300 } 279 }
280
281 yuv_quad->SetNew(shared_state, rect, opaque_rect, visible_rect,
282 ya_tex_coord_rect, uv_tex_coord_rect, ya_tex_size,
283 uv_tex_size, y_resource, u_resource, v_resource, a_resource,
284 color_space, video_color_space, 0.0f, 1.0f,
285 bits_per_channel);
301 } 286 }
302 287
303 void CreateTestY16TextureDrawQuad_FromVideoFrame( 288 void CreateTestY16TextureDrawQuad_FromVideoFrame(
304 const SharedQuadState* shared_state, 289 const SharedQuadState* shared_state,
305 scoped_refptr<media::VideoFrame> video_frame, 290 scoped_refptr<media::VideoFrame> video_frame,
306 const gfx::RectF& tex_coord_rect, 291 const gfx::RectF& tex_coord_rect,
307 RenderPass* render_pass, 292 RenderPass* render_pass,
308 VideoResourceUpdater* video_resource_updater, 293 VideoResourceUpdater* video_resource_updater,
309 const gfx::Rect& rect, 294 const gfx::Rect& rect,
310 const gfx::Rect& visible_rect, 295 const gfx::Rect& visible_rect,
311 ResourceProvider* resource_provider) { 296 ResourceProvider* resource_provider) {
312 VideoFrameExternalResources resources = 297 VideoFrameExternalResources resources =
313 video_resource_updater->CreateExternalResourcesFromVideoFrame( 298 video_resource_updater->CreateExternalResourcesFromVideoFrame(
314 video_frame); 299 video_frame);
315 300
316 EXPECT_EQ(VideoFrameExternalResources::RGBA_RESOURCE, resources.type); 301 EXPECT_EQ(VideoFrameExternalResources::RGBA_RESOURCE, resources.type);
317 EXPECT_EQ(1u, resources.mailboxes.size()); 302 EXPECT_EQ(1u, resources.mailboxes.size());
318 EXPECT_EQ(1u, resources.release_callbacks.size()); 303 EXPECT_EQ(1u, resources.release_callbacks.size());
319 304
320 ResourceId y_resource = resource_provider->CreateResourceFromTextureMailbox( 305 ResourceId y_resource = resource_provider->CreateResourceFromTextureMailbox(
321 resources.mailboxes[0], 306 resources.mailboxes[0],
322 SingleReleaseCallbackImpl::Create(resources.release_callbacks[0])); 307 SingleReleaseCallbackImpl::Create(resources.release_callbacks[0]));
323 308
324 TextureDrawQuad* quad = 309 TextureDrawQuad* quad =
325 render_pass->CreateAndAppendDrawQuad<TextureDrawQuad>(); 310 render_pass->CreateAndAppendDrawQuad<TextureDrawQuad>();
326 float vertex_opacity[4] = {1.0f, 1.0f, 1.0f, 1.0f}; 311 float vertex_opacity[4] = {1.0f, 1.0f, 1.0f, 1.0f};
327 quad->SetNew(shared_state, rect, gfx::Rect(), visible_rect, y_resource, false, 312 quad->SetNew(shared_state, rect, gfx::Rect(), rect, y_resource, false,
328 tex_coord_rect.origin(), tex_coord_rect.bottom_right(), 313 tex_coord_rect.origin(), tex_coord_rect.bottom_right(),
329 SK_ColorBLACK, vertex_opacity, false, false, false); 314 SK_ColorBLACK, vertex_opacity, false, false, false);
330 } 315 }
331 316
332 // Upshift video frame to 10 bit. 317 // Upshift video frame to 10 bit.
333 scoped_refptr<media::VideoFrame> CreateHighbitVideoFrame( 318 scoped_refptr<media::VideoFrame> CreateHighbitVideoFrame(
334 media::VideoFrame* video_frame) { 319 media::VideoFrame* video_frame) {
335 media::VideoPixelFormat format; 320 media::VideoPixelFormat format;
336 switch (video_frame->format()) { 321 switch (video_frame->format()) {
337 case media::PIXEL_FORMAT_I420: 322 case media::PIXEL_FORMAT_I420:
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 bool is_transparent, 365 bool is_transparent,
381 bool highbit, 366 bool highbit,
382 const gfx::RectF& tex_coord_rect, 367 const gfx::RectF& tex_coord_rect,
383 RenderPass* render_pass, 368 RenderPass* render_pass,
384 VideoResourceUpdater* video_resource_updater, 369 VideoResourceUpdater* video_resource_updater,
385 const gfx::Rect& rect, 370 const gfx::Rect& rect,
386 const gfx::Rect& visible_rect, 371 const gfx::Rect& visible_rect,
387 ResourceProvider* resource_provider) { 372 ResourceProvider* resource_provider) {
388 scoped_refptr<media::VideoFrame> video_frame = media::VideoFrame::CreateFrame( 373 scoped_refptr<media::VideoFrame> video_frame = media::VideoFrame::CreateFrame(
389 format, rect.size(), rect, rect.size(), base::TimeDelta()); 374 format, rect.size(), rect, rect.size(), base::TimeDelta());
390 video_frame->metadata()->SetInteger(media::VideoFrameMetadata::COLOR_SPACE,
391 media::COLOR_SPACE_JPEG);
392 375
393 // YUV values representing a striped pattern, for validating texture 376 // YUV values representing a striped pattern, for validating texture
394 // coordinates for sampling. 377 // coordinates for sampling.
395 uint8_t y_value = 0; 378 uint8_t y_value = 0;
396 uint8_t u_value = 0; 379 uint8_t u_value = 0;
397 uint8_t v_value = 0; 380 uint8_t v_value = 0;
398 for (int i = 0; i < video_frame->rows(media::VideoFrame::kYPlane); ++i) { 381 for (int i = 0; i < video_frame->rows(media::VideoFrame::kYPlane); ++i) {
399 uint8_t* y_row = video_frame->data(media::VideoFrame::kYPlane) + 382 uint8_t* y_row = video_frame->data(media::VideoFrame::kYPlane) +
400 video_frame->stride(media::VideoFrame::kYPlane) * i; 383 video_frame->stride(media::VideoFrame::kYPlane) * i;
401 for (int j = 0; j < video_frame->row_bytes(media::VideoFrame::kYPlane); 384 for (int j = 0; j < video_frame->row_bytes(media::VideoFrame::kYPlane);
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 508
526 uint8_t alpha_value = is_transparent ? 0 : 128; 509 uint8_t alpha_value = is_transparent ? 0 : 128;
527 CreateTestYUVVideoDrawQuad_FromVideoFrame( 510 CreateTestYUVVideoDrawQuad_FromVideoFrame(
528 shared_state, video_frame, alpha_value, tex_coord_rect, render_pass, 511 shared_state, video_frame, alpha_value, tex_coord_rect, render_pass,
529 video_resource_updater, rect, visible_rect, resource_provider); 512 video_resource_updater, rect, visible_rect, resource_provider);
530 } 513 }
531 514
532 void CreateTestYUVVideoDrawQuad_NV12(const SharedQuadState* shared_state, 515 void CreateTestYUVVideoDrawQuad_NV12(const SharedQuadState* shared_state,
533 media::ColorSpace video_frame_color_space, 516 media::ColorSpace video_frame_color_space,
534 const gfx::ColorSpace& video_color_space, 517 const gfx::ColorSpace& video_color_space,
535 ResourceFormat y_format,
536 const gfx::RectF& tex_coord_rect, 518 const gfx::RectF& tex_coord_rect,
537 uint8_t y, 519 uint8_t y,
538 uint8_t u, 520 uint8_t u,
539 uint8_t v, 521 uint8_t v,
540 RenderPass* render_pass, 522 RenderPass* render_pass,
541 const gfx::Rect& rect, 523 const gfx::Rect& rect,
542 const gfx::Rect& visible_rect, 524 const gfx::Rect& visible_rect,
543 ResourceProvider* resource_provider) { 525 ResourceProvider* resource_provider) {
544 YUVVideoDrawQuad::ColorSpace color_space = YUVVideoDrawQuad::REC_601; 526 YUVVideoDrawQuad::ColorSpace color_space = YUVVideoDrawQuad::REC_601;
545 if (video_frame_color_space == media::COLOR_SPACE_JPEG) { 527 if (video_frame_color_space == media::COLOR_SPACE_JPEG) {
546 color_space = YUVVideoDrawQuad::JPEG; 528 color_space = YUVVideoDrawQuad::JPEG;
547 } 529 }
548 530
549 const gfx::Rect opaque_rect(0, 0, 0, 0); 531 const gfx::Rect opaque_rect(0, 0, 0, 0);
550 const gfx::Size ya_tex_size = rect.size(); 532 const gfx::Size ya_tex_size = rect.size();
551 const gfx::Size uv_tex_size = media::VideoFrame::PlaneSize( 533 const gfx::Size uv_tex_size = media::VideoFrame::PlaneSize(
552 media::PIXEL_FORMAT_NV12, media::VideoFrame::kUVPlane, rect.size()); 534 media::PIXEL_FORMAT_NV12, media::VideoFrame::kUVPlane, rect.size());
553 535
554 ResourceId y_resource = resource_provider->CreateResource( 536 ResourceId y_resource = resource_provider->CreateResource(
555 rect.size(), ResourceProvider::TEXTURE_HINT_DEFAULT, y_format, 537 rect.size(), ResourceProvider::TEXTURE_HINT_DEFAULT,
556 gfx::ColorSpace()); 538 resource_provider->YuvResourceFormat(8), gfx::ColorSpace());
557 ResourceId u_resource = resource_provider->CreateResource( 539 ResourceId u_resource = resource_provider->CreateResource(
558 uv_tex_size, ResourceProvider::TEXTURE_HINT_DEFAULT, RGBA_8888, 540 uv_tex_size, ResourceProvider::TEXTURE_HINT_DEFAULT, RGBA_8888,
559 gfx::ColorSpace()); 541 gfx::ColorSpace());
560 ResourceId v_resource = u_resource; 542 ResourceId v_resource = u_resource;
561 ResourceId a_resource = 0; 543 ResourceId a_resource = 0;
562 544
563 std::vector<uint8_t> y_pixels(ya_tex_size.GetArea(), y); 545 std::vector<uint8_t> y_pixels(ya_tex_size.GetArea(), y);
564 resource_provider->CopyToResource(y_resource, y_pixels.data(), ya_tex_size); 546 resource_provider->CopyToResource(y_resource, y_pixels.data(), ya_tex_size);
565 547
566 // U goes in the R component and V goes in the G component. 548 // U goes in the R component and V goes in the G component.
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 resource_provider_.get()); 1188 resource_provider_.get());
1207 pass_list->push_back(std::move(pass)); 1189 pass_list->push_back(std::move(pass));
1208 } 1190 }
1209 1191
1210 void SetUp() override { 1192 void SetUp() override {
1211 GLRendererPixelTest::SetUp(); 1193 GLRendererPixelTest::SetUp();
1212 video_resource_updater_.reset(new VideoResourceUpdater( 1194 video_resource_updater_.reset(new VideoResourceUpdater(
1213 output_surface_->context_provider(), resource_provider_.get())); 1195 output_surface_->context_provider(), resource_provider_.get()));
1214 } 1196 }
1215 1197
1216 void DisableOneComponentTextures() {
1217 TestInProcessContextProvider* context_provider =
1218 GetTestInProcessContextProvider();
1219 context_provider->SetDisableOneComponentTextures(true);
1220 }
1221
1222 std::unique_ptr<VideoResourceUpdater> video_resource_updater_; 1198 std::unique_ptr<VideoResourceUpdater> video_resource_updater_;
1223
1224 protected:
1225 TestInProcessContextProvider* GetTestInProcessContextProvider() {
1226 return static_cast<TestInProcessContextProvider*>(
1227 output_surface_->context_provider());
1228 }
1229 };
1230
1231 enum class HighbitTexture {
1232 Y8,
1233 RGBA_8888,
1234 LUMINANCE_F16, // need --use-gpu-in-tests
1235 }; 1199 };
1236 1200
1237 class VideoGLRendererPixelHiLoTest 1201 class VideoGLRendererPixelHiLoTest
1238 : public VideoGLRendererPixelTest, 1202 : public VideoGLRendererPixelTest,
1239 public ::testing::WithParamInterface< 1203 public ::testing::WithParamInterface<bool> {};
1240 ::testing::tuple<bool, HighbitTexture>> {
1241 public:
1242 void SetSupportHighbitTexture(HighbitTexture texture) {
1243 TestInProcessContextProvider* context_provider =
1244 GetTestInProcessContextProvider();
1245 switch (texture) {
1246 case HighbitTexture::Y8:
1247 context_provider->SetDisableOneComponentTextures(false);
1248 context_provider->SetSupportTextureHalfFloatLinear(false);
1249 break;
1250 case HighbitTexture::RGBA_8888:
1251 context_provider->SetDisableOneComponentTextures(true);
1252 context_provider->SetSupportTextureHalfFloatLinear(false);
1253 break;
1254 case HighbitTexture::LUMINANCE_F16:
1255 context_provider->SetDisableOneComponentTextures(false);
1256 context_provider->SetSupportTextureHalfFloatLinear(true);
1257 break;
1258 }
1259 }
1260
1261 bool IsHalfFloatLinearSupported() {
1262 if (extensions_.empty())
1263 InitializeExtensions();
1264
1265 return extensions_.find("GL_OES_texture_half_float_linear") !=
1266 extensions_.end();
1267 }
1268
1269 private:
1270 void InitializeExtensions() {
1271 std::string extensions = GetTestInProcessContextProvider()
1272 ->ContextGL()
1273 ->GetRequestableExtensionsCHROMIUM();
1274 std::vector<std::string> tokens = base::SplitString(
1275 extensions, " ", base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
1276 extensions_.insert(tokens.begin(), tokens.end());
1277 }
1278
1279 std::set<std::string> extensions_;
1280 };
1281 1204
1282 TEST_P(VideoGLRendererPixelHiLoTest, SimpleYUVRect) { 1205 TEST_P(VideoGLRendererPixelHiLoTest, SimpleYUVRect) {
1283 gfx::Rect rect(this->device_viewport_size_); 1206 gfx::Rect rect(this->device_viewport_size_);
1284 1207
1285 RenderPassId id(1, 1); 1208 RenderPassId id(1, 1);
1286 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 1209 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
1287 1210
1288 SharedQuadState* shared_state = 1211 SharedQuadState* shared_state =
1289 CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 1212 CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
1290 1213
1291 const bool highbit = testing::get<0>(GetParam()); 1214 bool highbit = GetParam();
1292 const HighbitTexture format = testing::get<1>(GetParam());
1293 if (format == HighbitTexture::LUMINANCE_F16 && !IsHalfFloatLinearSupported())
1294 return;
1295
1296 SetSupportHighbitTexture(format);
1297 CreateTestYUVVideoDrawQuad_Striped( 1215 CreateTestYUVVideoDrawQuad_Striped(
1298 shared_state, media::PIXEL_FORMAT_YV12, false, highbit, 1216 shared_state, media::PIXEL_FORMAT_YV12, false, highbit,
1299 gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), pass.get(), 1217 gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), pass.get(),
1300 video_resource_updater_.get(), rect, rect, resource_provider_.get()); 1218 video_resource_updater_.get(), rect, rect, resource_provider_.get());
1301 1219
1302 RenderPassList pass_list; 1220 RenderPassList pass_list;
1303 pass_list.push_back(std::move(pass)); 1221 pass_list.push_back(std::move(pass));
1304 1222
1305 base::FilePath file_path = 1223 EXPECT_TRUE(
1306 base::FilePath(FILE_PATH_LITERAL("yuv_stripes.png")); 1224 this->RunPixelTest(&pass_list,
1307 // TODO(dshwang): investigate why results per configuraion are so different. 1225 base::FilePath(FILE_PATH_LITERAL("yuv_stripes.png")),
1308 // crbug.com/622133 1226 FuzzyPixelOffByOneComparator(true)));
1309 if (format == HighbitTexture::RGBA_8888) {
1310 // Color space is so different, because this path doesn't respect video
1311 // color profile.
1312 file_path = base::FilePath(FILE_PATH_LITERAL("yuv_stripes_rgba.png"));
1313 }
1314 EXPECT_TRUE(this->RunPixelTest(
1315 &pass_list, file_path,
1316 // All pixels can be off by two, but any more than that is an error.
1317 FuzzyPixelComparator(true, 100.f, 0.f, 2.f, 2, 0)));
1318 } 1227 }
1319 1228
1320 TEST_P(VideoGLRendererPixelHiLoTest, ClippedYUVRect) { 1229 TEST_P(VideoGLRendererPixelHiLoTest, ClippedYUVRect) {
1321 gfx::Rect viewport(this->device_viewport_size_); 1230 gfx::Rect viewport(this->device_viewport_size_);
1322 gfx::Rect draw_rect(this->device_viewport_size_.width() * 1.5, 1231 gfx::Rect draw_rect(this->device_viewport_size_.width() * 1.5,
1323 this->device_viewport_size_.height() * 1.5); 1232 this->device_viewport_size_.height() * 1.5);
1324 1233
1325 RenderPassId id(1, 1); 1234 RenderPassId id(1, 1);
1326 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, viewport); 1235 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, viewport);
1327 1236
1328 SharedQuadState* shared_state = 1237 SharedQuadState* shared_state =
1329 CreateTestSharedQuadState(gfx::Transform(), viewport, pass.get()); 1238 CreateTestSharedQuadState(gfx::Transform(), viewport, pass.get());
1330 1239
1331 const bool highbit = testing::get<0>(GetParam()); 1240 bool highbit = GetParam();
1332 const HighbitTexture format = testing::get<1>(GetParam());
1333 if (format == HighbitTexture::LUMINANCE_F16 && !IsHalfFloatLinearSupported())
1334 return;
1335
1336 SetSupportHighbitTexture(format);
1337 CreateTestYUVVideoDrawQuad_Striped( 1241 CreateTestYUVVideoDrawQuad_Striped(
1338 shared_state, media::PIXEL_FORMAT_YV12, false, highbit, 1242 shared_state, media::PIXEL_FORMAT_YV12, false, highbit,
1339 gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), pass.get(), 1243 gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), pass.get(),
1340 video_resource_updater_.get(), draw_rect, viewport, 1244 video_resource_updater_.get(), draw_rect, viewport,
1341 resource_provider_.get()); 1245 resource_provider_.get());
1342 RenderPassList pass_list; 1246 RenderPassList pass_list;
1343 pass_list.push_back(std::move(pass)); 1247 pass_list.push_back(std::move(pass));
1344 1248
1345 base::FilePath file_path =
1346 base::FilePath(FILE_PATH_LITERAL("yuv_stripes_clipped.png"));
1347 if (format == HighbitTexture::RGBA_8888) {
1348 file_path =
1349 base::FilePath(FILE_PATH_LITERAL("yuv_stripes_clipped_rgba.png"));
1350 }
1351 EXPECT_TRUE(this->RunPixelTest( 1249 EXPECT_TRUE(this->RunPixelTest(
1352 &pass_list, file_path, 1250 &pass_list, base::FilePath(FILE_PATH_LITERAL("yuv_stripes_clipped.png")),
1353 // All pixels can be off by two, but any more than that is an error. 1251 FuzzyPixelOffByOneComparator(true)));
1354 FuzzyPixelComparator(true, 100.f, 0.f, 2.f, 2, 0)));
1355 } 1252 }
1356 1253
1357 TEST_F(VideoGLRendererPixelHiLoTest, OffsetYUVRect) { 1254 TEST_F(VideoGLRendererPixelHiLoTest, OffsetYUVRect) {
1358 gfx::Rect rect(this->device_viewport_size_); 1255 gfx::Rect rect(this->device_viewport_size_);
1359 1256
1360 RenderPassId id(1, 1); 1257 RenderPassId id(1, 1);
1361 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 1258 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
1362 1259
1363 SharedQuadState* shared_state = 1260 SharedQuadState* shared_state =
1364 CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 1261 CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
1396 pass_list.push_back(std::move(pass)); 1293 pass_list.push_back(std::move(pass));
1397 1294
1398 // If we didn't get black out of the YUV values above, then we probably have a 1295 // If we didn't get black out of the YUV values above, then we probably have a
1399 // color range issue. 1296 // color range issue.
1400 EXPECT_TRUE(this->RunPixelTest(&pass_list, 1297 EXPECT_TRUE(this->RunPixelTest(&pass_list,
1401 base::FilePath(FILE_PATH_LITERAL("black.png")), 1298 base::FilePath(FILE_PATH_LITERAL("black.png")),
1402 FuzzyPixelOffByOneComparator(true))); 1299 FuzzyPixelOffByOneComparator(true)));
1403 } 1300 }
1404 1301
1405 // First argument (test case prefix) is intentionally left empty. 1302 // First argument (test case prefix) is intentionally left empty.
1406 INSTANTIATE_TEST_CASE_P( 1303 INSTANTIATE_TEST_CASE_P(, VideoGLRendererPixelHiLoTest, ::testing::Bool());
1407 ,
1408 VideoGLRendererPixelHiLoTest,
1409 ::testing::Combine(::testing::Bool(),
1410 ::testing::Values(HighbitTexture::Y8,
1411 HighbitTexture::LUMINANCE_F16,
1412 HighbitTexture::RGBA_8888)));
1413 1304
1414 TEST_F(VideoGLRendererPixelTest, SimpleYUVJRect) { 1305 TEST_F(VideoGLRendererPixelTest, SimpleYUVJRect) {
1415 gfx::Rect rect(this->device_viewport_size_); 1306 gfx::Rect rect(this->device_viewport_size_);
1416 1307
1417 RenderPassId id(1, 1); 1308 RenderPassId id(1, 1);
1418 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 1309 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
1419 1310
1420 SharedQuadState* shared_state = 1311 SharedQuadState* shared_state =
1421 CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 1312 CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
1422 1313
(...skipping 13 matching lines...) Expand all
1436 1327
1437 TEST_F(VideoGLRendererPixelTest, SimpleNV12JRect) { 1328 TEST_F(VideoGLRendererPixelTest, SimpleNV12JRect) {
1438 gfx::Rect rect(this->device_viewport_size_); 1329 gfx::Rect rect(this->device_viewport_size_);
1439 1330
1440 RenderPassId id(1, 1); 1331 RenderPassId id(1, 1);
1441 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 1332 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
1442 1333
1443 SharedQuadState* shared_state = 1334 SharedQuadState* shared_state =
1444 CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 1335 CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
1445 1336
1446 ResourceFormat y_format =
1447 video_resource_updater_->YuvResourceFormat(8, media::PIXEL_FORMAT_NV12);
1448
1449 // YUV of (149,43,21) should be green (0,255,0) in RGB. 1337 // YUV of (149,43,21) should be green (0,255,0) in RGB.
1450 CreateTestYUVVideoDrawQuad_NV12( 1338 CreateTestYUVVideoDrawQuad_NV12(
1451 shared_state, media::COLOR_SPACE_JPEG, gfx::ColorSpace::CreateJpeg(), 1339 shared_state, media::COLOR_SPACE_JPEG, gfx::ColorSpace::CreateJpeg(),
1452 y_format, gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 149, 43, 21, pass.get(), 1340 gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 149, 43, 21, pass.get(), rect, rect,
1453 rect, rect, resource_provider_.get()); 1341 resource_provider_.get());
1454 1342
1455 RenderPassList pass_list; 1343 RenderPassList pass_list;
1456 pass_list.push_back(std::move(pass)); 1344 pass_list.push_back(std::move(pass));
1457 1345
1458 EXPECT_TRUE(this->RunPixelTest(&pass_list, 1346 EXPECT_TRUE(this->RunPixelTest(&pass_list,
1459 base::FilePath(FILE_PATH_LITERAL("green.png")), 1347 base::FilePath(FILE_PATH_LITERAL("green.png")),
1460 FuzzyPixelOffByOneComparator(true))); 1348 FuzzyPixelOffByOneComparator(true)));
1461 } 1349 }
1462 1350
1463 // Test that a YUV video doesn't bleed outside of its tex coords when the 1351 // Test that a YUV video doesn't bleed outside of its tex coords when the
1464 // tex coord rect is only a partial subrectangle of the coded contents. 1352 // tex coord rect is only a partial subrectangle of the coded contents.
1465 TEST_F(VideoGLRendererPixelTest, YUVEdgeBleed) { 1353 TEST_F(VideoGLRendererPixelTest, YUVEdgeBleed) {
1466 RenderPassList pass_list; 1354 RenderPassList pass_list;
1467 CreateEdgeBleedPass(media::PIXEL_FORMAT_YV12, media::COLOR_SPACE_JPEG, 1355 CreateEdgeBleedPass(media::PIXEL_FORMAT_YV12, media::COLOR_SPACE_JPEG,
1468 &pass_list); 1356 &pass_list);
1469 EXPECT_TRUE(this->RunPixelTest(&pass_list, 1357 EXPECT_TRUE(this->RunPixelTest(&pass_list,
1470 base::FilePath(FILE_PATH_LITERAL("green.png")), 1358 base::FilePath(FILE_PATH_LITERAL("green.png")),
1471 FuzzyPixelOffByOneComparator(true))); 1359 FuzzyPixelOffByOneComparator(true)));
1472 } 1360 }
1473 1361
1474 TEST_F(VideoGLRendererPixelTest, YUVAEdgeBleed) { 1362 TEST_F(VideoGLRendererPixelTest, YUVAEdgeBleed) {
1475 RenderPassList pass_list; 1363 RenderPassList pass_list;
1476 CreateEdgeBleedPass(media::PIXEL_FORMAT_YV12A, media::COLOR_SPACE_UNSPECIFIED, 1364 CreateEdgeBleedPass(media::PIXEL_FORMAT_YV12A, media::COLOR_SPACE_UNSPECIFIED,
1477 &pass_list); 1365 &pass_list);
1478 EXPECT_TRUE(this->RunPixelTest(&pass_list, 1366 EXPECT_TRUE(this->RunPixelTest(&pass_list,
1479 base::FilePath(FILE_PATH_LITERAL("green.png")), 1367 base::FilePath(FILE_PATH_LITERAL("green.png")),
1480 FuzzyPixelOffByOneComparator(true)));
1481 }
1482
1483 TEST_F(VideoGLRendererPixelTest, TextureQuadEdgeBleed) {
1484 // VideoResourceUpdater::CreateForSoftwarePlanes() converts YUV frame to RGBA
1485 // texture.
1486 DisableOneComponentTextures();
1487 RenderPassList pass_list;
1488 CreateEdgeBleedPass(media::PIXEL_FORMAT_YV12, media::COLOR_SPACE_JPEG,
1489 &pass_list);
1490 EXPECT_TRUE(this->RunPixelTest(&pass_list,
1491 base::FilePath(FILE_PATH_LITERAL("green.png")),
1492 FuzzyPixelOffByOneComparator(true))); 1368 FuzzyPixelOffByOneComparator(true)));
1493 } 1369 }
1494 1370
1495 TEST_F(VideoGLRendererPixelTest, SimpleYUVJRectGrey) { 1371 TEST_F(VideoGLRendererPixelTest, SimpleYUVJRectGrey) {
1496 gfx::Rect rect(this->device_viewport_size_); 1372 gfx::Rect rect(this->device_viewport_size_);
1497 1373
1498 RenderPassId id(1, 1); 1374 RenderPassId id(1, 1);
1499 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 1375 std::unique_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
1500 1376
1501 SharedQuadState* shared_state = 1377 SharedQuadState* shared_state =
(...skipping 1894 matching lines...) Expand 10 before | Expand all | Expand 10 after
3396 3272
3397 EXPECT_TRUE(this->RunPixelTest( 3273 EXPECT_TRUE(this->RunPixelTest(
3398 &pass_list, base::FilePath(FILE_PATH_LITERAL("spiral.png")), 3274 &pass_list, base::FilePath(FILE_PATH_LITERAL("spiral.png")),
3399 FuzzyPixelOffByOneComparator(true))); 3275 FuzzyPixelOffByOneComparator(true)));
3400 } 3276 }
3401 3277
3402 #endif // !defined(OS_ANDROID) 3278 #endif // !defined(OS_ANDROID)
3403 3279
3404 } // namespace 3280 } // namespace
3405 } // namespace cc 3281 } // namespace cc
OLDNEW
« no previous file with comments | « cc/output/gl_renderer_draw_cache.h ('k') | cc/output/shader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698