Fix under-invalidation of frameset on resize

Fix under-invalidation of frameset on resize

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   the frames cover changed part of the frameset.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fc09797d2841a0da450266e2fd004d9e12c7b020
Cr-Commit-Position: refs/heads/master@{#435724}

[Xianzhu, 2016-12-01 05:11:39]

Description was changed from

==========
Fix under-invalidation of frameset on resize

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   the frames cover changed part of the frameset.

Added verification of
LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize().
The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

BUG=669327
==========

to

==========
Fix under-invalidation of frameset on resize

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   the frames cover changed part of the frameset.

Added verification of
LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize().
The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-01 05:11:57]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 05:12:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 05:25:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 05:25:19]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)

[Xianzhu, 2016-12-01 05:44:07]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 05:44:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 07:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 07:04:39]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Xianzhu, 2016-12-01 17:16:20]

Description was changed from

==========
Fix under-invalidation of frameset on resize

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   the frames cover changed part of the frameset.

Added verification of
LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize().
The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix under-invalidation of frameset on resize

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   the frames cover changed part of the frameset.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-01 17:16:24]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 17:16:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 17:27:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 17:27:56]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Xianzhu, 2016-12-01 18:14:46]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 18:15:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-01 18:17:01]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-12-01 18:17:01]

To prevent such errors, I created a patch
https://codereview.chromium.org/2541293002 to verify
paintedOutputOfObjectHasNoEffectRegardlessOfSize() during painting.

[chrishtr, 2016-12-01 20:59:18]

On 2016/12/01 at 18:17:01, wangxianzhu wrote:
> To prevent such errors, I created a patch
https://codereview.chromium.org/2541293002 to verify
paintedOutputOfObjectHasNoEffectRegardlessOfSize() during painting.

I think you referred to the wrong patch in your comment?

[chrishtr, 2016-12-01 20:59:37]

lgtm

[commit-bot: I haz the power, 2016-12-01 21:33:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:33:21]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-12-01 21:35:33]

On 2016/12/01 20:59:18, chrishtr wrote:
> On 2016/12/01 at 18:17:01, wangxianzhu wrote:
> > To prevent such errors, I created a patch
> https://codereview.chromium.org/2541293002 to verify
> paintedOutputOfObjectHasNoEffectRegardlessOfSize() during painting.
> 
> I think you referred to the wrong patch in your comment?

It should be https://codereview.chromium.org/2549553002/.

[Xianzhu, 2016-12-01 21:35:38]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:35:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:41:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480628138459690,
"parent_rev": "0a2982758983df86b81572a0340755dff10c6774", "commit_rev":
"267d46f158881149d7df902ea64806229662f6f9"}

[commit-bot: I haz the power, 2016-12-01 21:41:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-01 21:46:13]

Description was changed from

==========
Fix under-invalidation of frameset on resize

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   the frames cover changed part of the frameset.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix under-invalidation of frameset on resize

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   the frames cover changed part of the frameset.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fc09797d2841a0da450266e2fd004d9e12c7b020
Cr-Commit-Position: refs/heads/master@{#435724}
==========

[commit-bot: I haz the power, 2016-12-01 21:46:14]

Patchset 4 (id:??) landed as
https://crrev.com/fc09797d2841a0da450266e2fd004d9e12c7b020
Cr-Commit-Position: refs/heads/master@{#435724}