Fix under-invalidation of multicol with rule

Fix under-invalidation of multicol with rule

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c168a7fa67c6efca565cba673dda7bc8fc3d976b
Cr-Commit-Position: refs/heads/master@{#435826}

[Xianzhu, 2016-12-01 05:14:20]

Description was changed from

==========
Fix under-invalidation of frameset and multicol with rule

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   frames cover the changed part of the frameset.

BUG=669327
==========

to

==========
Fix under-invalidation of frameset and multicol with rule

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   frames cover the changed part of the frameset.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-01 05:14:26]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 05:14:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 05:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 05:28:13]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-12-01 05:45:54]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 05:46:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 06:35:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 06:35:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-12-01 17:19:26]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 17:20:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 17:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 17:30:27]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-12-01 18:08:25]

Description was changed from

==========
Fix under-invalidation of frameset and multicol with rule

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   frames cover the changed part of the frameset.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix under-invalidation of multicol with rule

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   frames cover the changed part of the frameset.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-01 18:08:57]

Description was changed from

==========
Fix under-invalidation of multicol with rule

Previously frameset had two problems:
1. (m-54 regression caused by https://codereview.chromium.org/2203933002)
   LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize()
   returned true for frameset causing no invalidation when a frameset is
   resized.
2. (Not a regression) frameset should not do incremental invalidation.
   This didn't cause problem because the raster invalidation rects of
   frames cover the changed part of the frameset.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix under-invalidation of multicol with rule

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-01 18:15:16]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 18:15:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-01 18:18:16]

Description was changed from

==========
Fix under-invalidation of multicol with rule

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix under-invalidation of multicol with rule

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-01 18:19:09]

wangxianzhu@chromium.org changed reviewers:
+ wkorman@chromium.org

[Xianzhu, 2016-12-01 18:19:10]

This is an old bug that hasn't been reported or covered by any test.

[wkorman, 2016-12-01 18:43:00]

lgtm

[commit-bot: I haz the power, 2016-12-01 19:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 19:44:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-12-01 22:20:35]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-01 22:20:36]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2541293002/#ps80001
(title: "Fix test")

[commit-bot: I haz the power, 2016-12-01 22:21:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 02:17:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480630835861410,
"parent_rev": "faa693f93a64d06821331d8a4f83fce9c819f47a", "commit_rev":
"21431fe45ccf03895e03433e96a5629cae34fadd"}

[commit-bot: I haz the power, 2016-12-02 02:17:32]

Description was changed from

==========
Fix under-invalidation of multicol with rule

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix under-invalidation of multicol with rule

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-12-02 02:17:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-02 02:19:53]

Description was changed from

==========
Fix under-invalidation of multicol with rule

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix under-invalidation of multicol with rule

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c168a7fa67c6efca565cba673dda7bc8fc3d976b
Cr-Commit-Position: refs/heads/master@{#435826}
==========

[commit-bot: I haz the power, 2016-12-02 02:19:57]

Patchset 5 (id:??) landed as
https://crrev.com/c168a7fa67c6efca565cba673dda7bc8fc3d976b
Cr-Commit-Position: refs/heads/master@{#435826}