Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Issue 2544743002: Fix under-invalidation of frameset on resize (Closed)
Patch Set: - Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFrameSet.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/paint/BoxPaintInvalidator.h" 5 #include "core/paint/BoxPaintInvalidator.h"
6 6
7 #include "core/frame/Settings.h" 7 #include "core/frame/Settings.h"
8 #include "core/layout/LayoutView.h" 8 #include "core/layout/LayoutView.h"
9 #include "core/layout/compositing/CompositedLayerMapping.h" 9 #include "core/layout/compositing/CompositedLayerMapping.h"
10 #include "core/paint/ObjectPaintInvalidator.h" 10 #include "core/paint/ObjectPaintInvalidator.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 if (style.hasBorderRadius()) 151 if (style.hasBorderRadius())
152 return PaintInvalidationBorderBoxChange; 152 return PaintInvalidationBorderBoxChange;
153 153
154 if (oldBorderBoxSize.width() != newBorderBoxSize.width() && 154 if (oldBorderBoxSize.width() != newBorderBoxSize.width() &&
155 m_box.mustInvalidateBackgroundOrBorderPaintOnWidthChange()) 155 m_box.mustInvalidateBackgroundOrBorderPaintOnWidthChange())
156 return PaintInvalidationBorderBoxChange; 156 return PaintInvalidationBorderBoxChange;
157 if (oldBorderBoxSize.height() != newBorderBoxSize.height() && 157 if (oldBorderBoxSize.height() != newBorderBoxSize.height() &&
158 m_box.mustInvalidateBackgroundOrBorderPaintOnHeightChange()) 158 m_box.mustInvalidateBackgroundOrBorderPaintOnHeightChange())
159 return PaintInvalidationBorderBoxChange; 159 return PaintInvalidationBorderBoxChange;
160 160
161 // Needs to repaint frame boundaries.
162 if (m_box.isFrameSet())
163 return PaintInvalidationBorderBoxChange;
164
161 return PaintInvalidationIncremental; 165 return PaintInvalidationIncremental;
162 } 166 }
163 167
164 bool BoxPaintInvalidator::backgroundGeometryDependsOnLayoutOverflowRect() { 168 bool BoxPaintInvalidator::backgroundGeometryDependsOnLayoutOverflowRect() {
165 return !m_box.isDocumentElement() && !m_box.backgroundStolenForBeingBody() && 169 return !m_box.isDocumentElement() && !m_box.backgroundStolenForBeingBody() &&
166 m_box.styleRef() 170 m_box.styleRef()
167 .backgroundLayers() 171 .backgroundLayers()
168 .thisOrNextLayersHaveLocalAttachment(); 172 .thisOrNextLayersHaveLocalAttachment();
169 } 173 }
170 174
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 375
372 LayoutRect BoxPaintInvalidator::previousLayoutOverflowRect() { 376 LayoutRect BoxPaintInvalidator::previousLayoutOverflowRect() {
373 DCHECK(m_box.hasPreviousBoxGeometries() == 377 DCHECK(m_box.hasPreviousBoxGeometries() ==
374 previousBoxGeometriesMap().contains(&m_box)); 378 previousBoxGeometriesMap().contains(&m_box));
375 return m_box.hasPreviousBoxGeometries() 379 return m_box.hasPreviousBoxGeometries()
376 ? previousBoxGeometriesMap().get(&m_box).layoutOverflowRect 380 ? previousBoxGeometriesMap().get(&m_box).layoutOverflowRect
377 : LayoutRect(); 381 : LayoutRect();
378 } 382 }
379 383
380 } // namespace blink 384 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFrameSet.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698