Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2543973002: Refactor kernel-related status files (Closed)

Created:
4 years ago by kustermann
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor kernel-related status files To make it clear in the status file whether a crash (or other issues) are coming from the dartk compiler or from the vm, this CL introduces new status file markers which are the normal markers prefixed with Dartk (e.g. DartkCrash). Furthermore this CL groups common failures * compiler: dartk & dartkp * runtime: vm & dart_precompiled into shared status file blocks, thereby deduplicating failures (which removes around 500 lines). R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/abd77cab640741fe654b4027956e9c34ba3f7603

Patch Set 1 #

Patch Set 2 : Small update (to make BB green, remove flaky marker) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -927 lines) Patch
M tests/co19/co19-kernel.status View 1 6 chunks +250 lines, -516 lines 0 comments Download
M tests/language/language_kernel.status View 1 9 chunks +117 lines, -407 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 2 chunks +23 lines, -4 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kustermann
4 years ago (2016-12-01 12:15:34 UTC) #3
Vyacheslav Egorov (Google)
lgtm
4 years ago (2016-12-01 12:34:46 UTC) #4
kustermann
4 years ago (2016-12-01 12:48:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
abd77cab640741fe654b4027956e9c34ba3f7603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698