Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: tools/testing/dart/status_file_parser.dart

Issue 2543973002: Refactor kernel-related status files (Closed)
Patch Set: Small update (to make BB green, remove flaky marker) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language_kernel.status ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/status_file_parser.dart
diff --git a/tools/testing/dart/status_file_parser.dart b/tools/testing/dart/status_file_parser.dart
index c4be8017191523a5e3afe638929c6032ac23ac35..a26c792b37d24f782281d1a8737dab37c881d5d7 100644
--- a/tools/testing/dart/status_file_parser.dart
+++ b/tools/testing/dart/status_file_parser.dart
@@ -28,6 +28,19 @@ class Expectation {
static Expectation MISSING_STATIC_WARNING = byName('MissingStaticWarning');
static Expectation PUB_GET_ERROR = byName('PubGetError');
+ // Special 'CRASH' cases
+ static Expectation DARTK_CRASH = byName('DartkCrash');
+
+ // Special 'TIMEOUT' cases
+ static Expectation DARTK_TIMEOUT = byName('DartkTimeout');
+
+ // Special 'MISSING_COMPILETIME_ERROR'
+ static Expectation DARTK_MISSING_COMPILETIME_ERROR =
+ byName('DartkMissingCompileTimeError');
+
+ // Special 'COMPILETIME_ERROR'
+ static Expectation DARTK_COMPILETIME_ERROR = byName('DartkCompileTimeError');
+
// "meta expectations"
static Expectation OK = byName('Ok');
static Expectation SLOW = byName('Slow');
@@ -63,15 +76,21 @@ class Expectation {
}
var fail = build("Fail");
+ var crash = build("Crash");
+ var timeout = build("Timeout");
build("Pass");
- build("Crash");
- build("Timeout");
- build("MissingCompileTimeError", group: fail);
+ var missingCompileError = build("MissingCompileTimeError", group: fail);
+ var compileError = build("CompileTimeError", group: fail);
build("MissingRuntimeError", group: fail);
- build("CompileTimeError", group: fail);
build("RuntimeError", group: fail);
+ // Dartk sub expectations
+ build("DartkCrash", group: crash);
+ build("DartkTimeout", group: timeout);
+ build("DartkMissingCompileTimeError", group: missingCompileError);
+ build("DartkCompileTimeError", group: compileError);
+
build("MissingStaticWarning", group: fail);
build("StaticWarning", group: fail);
« no previous file with comments | « tests/language/language_kernel.status ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698