Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 2543973002: Refactor kernel-related status files (Closed)
Patch Set: Small update (to make BB green, remove flaky marker) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1646 matching lines...) Expand 10 before | Expand all | Expand 10 after
1657 : super(command, exitCode, timedOut, stdout, stderr, time, 1657 : super(command, exitCode, timedOut, stdout, stderr, time,
1658 compilationSkipped); 1658 compilationSkipped);
1659 1659
1660 bool get canRunDependendCommands { 1660 bool get canRunDependendCommands {
1661 // See [BatchRunnerProcess]: 0 means success, 1 means compile-time error. 1661 // See [BatchRunnerProcess]: 0 means success, 1 means compile-time error.
1662 // TODO(asgerf): When the frontend supports it, continue running even if 1662 // TODO(asgerf): When the frontend supports it, continue running even if
1663 // there were compile-time errors. See kernel_sdk issue #18. 1663 // there were compile-time errors. See kernel_sdk issue #18.
1664 return !hasCrashed && !timedOut && exitCode == 0; 1664 return !hasCrashed && !timedOut && exitCode == 0;
1665 } 1665 }
1666 1666
1667 Expectation result(TestCase testCase) {
1668 Expectation result = super.result(testCase);
1669 if (result.canBeOutcomeOf(Expectation.CRASH)) {
1670 return Expectation.DARTK_CRASH;
1671 } else if (result.canBeOutcomeOf(Expectation.TIMEOUT)) {
1672 return Expectation.DARTK_TIMEOUT;
1673 } else if (result.canBeOutcomeOf(Expectation.MISSING_COMPILETIME_ERROR)) {
1674 return Expectation.DARTK_MISSING_COMPILETIME_ERROR;
1675 } else if (result.canBeOutcomeOf(Expectation.COMPILETIME_ERROR)) {
1676 return Expectation.DARTK_COMPILETIME_ERROR;
1677 }
1678 return result;
1679 }
1680
1667 // If the compiler was able to produce a Kernel IR file we want to run the 1681 // If the compiler was able to produce a Kernel IR file we want to run the
1668 // result on the Dart VM. We therefore mark the [KernelCompilationCommand] as 1682 // result on the Dart VM. We therefore mark the [KernelCompilationCommand] as
1669 // successful. 1683 // successful.
1670 // => This ensures we test that the DartVM produces correct CompileTime errors 1684 // => This ensures we test that the DartVM produces correct CompileTime errors
1671 // as it is supposed to for our test suites. 1685 // as it is supposed to for our test suites.
1672 bool get successful => canRunDependendCommands; 1686 bool get successful => canRunDependendCommands;
1673 } 1687 }
1674 1688
1675 class JsCommandlineOutputImpl extends CommandOutputImpl 1689 class JsCommandlineOutputImpl extends CommandOutputImpl
1676 with UnittestSuiteMessagesMixin { 1690 with UnittestSuiteMessagesMixin {
(...skipping 1463 matching lines...) Expand 10 before | Expand all | Expand 10 after
3140 } 3154 }
3141 } 3155 }
3142 3156
3143 void eventAllTestsDone() { 3157 void eventAllTestsDone() {
3144 for (var listener in _eventListener) { 3158 for (var listener in _eventListener) {
3145 listener.allDone(); 3159 listener.allDone();
3146 } 3160 }
3147 _allDone(); 3161 _allDone();
3148 } 3162 }
3149 } 3163 }
OLDNEW
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698