Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2543973002: Refactor kernel-related status files (Closed)
Patch Set: Small update (to make BB green, remove flaky marker) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 1cb1a3900edf351f6ac120afbb892f1dffb75864..177c82358157cd075465f84489dc2e90e00df45e 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1664,6 +1664,20 @@ class KernelCompilationCommandOutputImpl extends CompilationCommandOutputImpl {
return !hasCrashed && !timedOut && exitCode == 0;
}
+ Expectation result(TestCase testCase) {
+ Expectation result = super.result(testCase);
+ if (result.canBeOutcomeOf(Expectation.CRASH)) {
+ return Expectation.DARTK_CRASH;
+ } else if (result.canBeOutcomeOf(Expectation.TIMEOUT)) {
+ return Expectation.DARTK_TIMEOUT;
+ } else if (result.canBeOutcomeOf(Expectation.MISSING_COMPILETIME_ERROR)) {
+ return Expectation.DARTK_MISSING_COMPILETIME_ERROR;
+ } else if (result.canBeOutcomeOf(Expectation.COMPILETIME_ERROR)) {
+ return Expectation.DARTK_COMPILETIME_ERROR;
+ }
+ return result;
+ }
+
// If the compiler was able to produce a Kernel IR file we want to run the
// result on the Dart VM. We therefore mark the [KernelCompilationCommand] as
// successful.
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698