Bottom browser controls position based on window height

Bottom browser controls position based on window height

This change has the browser controls depend on the window viewport
rather than the visible viewport when drawing. This allows for the
math to be consistent across layouts that use the controls and
fixes the toolbar swipe layout.

To facilitate this, the SceneOverlay interface was updated to
include the window and visible viewports when updating their
respective SceneLayers.

BUG=652892
Committed: https://crrev.com/db62741d2a98508eae38f71a1e24672d66eda2f9
Cr-Commit-Position: refs/heads/master@{#437584}

[mdjones, 2016-12-02 18:26:52]

Description was changed from

==========
Bottom browser controls position based on window height

This change has the browser controls depend on the window viewport
rather than the visible viewport when drawing. This allows for the
math to be consistent across layouts that use the controls and
fixes the toolbar swipe layout.

A side effect of doing this is updating the SceneOverlay interface
to include the window and visible viewports when updating their
respective SceneLayers.

BUG=652892
==========

to

==========
Bottom browser controls position based on window height

This change has the browser controls depend on the window viewport
rather than the visible viewport when drawing. This allows for the
math to be consistent across layouts that use the controls and
fixes the toolbar swipe layout.

To facilitate this, the SceneOverlay interface was updated to
include the window and visible viewports when updating their
respective SceneLayers.

BUG=652892
==========

[mdjones, 2016-12-02 18:27:09]

mdjones@chromium.org changed reviewers:
+ dtrainor@chromium.org

[mdjones, 2016-12-02 18:27:10]

ptal

[David Trainor- moved to gerrit, 2016-12-08 23:46:19]

lgtm

[mdjones, 2016-12-09 01:45:16]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-12-09 01:45:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:49:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 01:49:16]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mdjones, 2016-12-09 01:52:55]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-12-09 01:53:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 01:56:18]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mdjones, 2016-12-09 17:10:49]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-12-09 17:10:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2542883004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-09 17:11:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 17:55:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481303449774660,
"parent_rev": "a4d99256a3c7603eae24f2a7d3892776fb2a5f09", "commit_rev":
"0e1f350f035e5c4f6faeb6597c93fc9ecb5e9cdc"}

[commit-bot: I haz the power, 2016-12-09 17:55:42]

Description was changed from

==========
Bottom browser controls position based on window height

This change has the browser controls depend on the window viewport
rather than the visible viewport when drawing. This allows for the
math to be consistent across layouts that use the controls and
fixes the toolbar swipe layout.

To facilitate this, the SceneOverlay interface was updated to
include the window and visible viewports when updating their
respective SceneLayers.

BUG=652892
==========

to

==========
Bottom browser controls position based on window height

This change has the browser controls depend on the window viewport
rather than the visible viewport when drawing. This allows for the
math to be consistent across layouts that use the controls and
fixes the toolbar swipe layout.

To facilitate this, the SceneOverlay interface was updated to
include the window and visible viewports when updating their
respective SceneLayers.

BUG=652892

Review-Url: https://codereview.chromium.org/2542883004
==========

[commit-bot: I haz the power, 2016-12-09 17:55:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 14:36:08]

Description was changed from

==========
Bottom browser controls position based on window height

This change has the browser controls depend on the window viewport
rather than the visible viewport when drawing. This allows for the
math to be consistent across layouts that use the controls and
fixes the toolbar swipe layout.

To facilitate this, the SceneOverlay interface was updated to
include the window and visible viewports when updating their
respective SceneLayers.

BUG=652892

Review-Url: https://codereview.chromium.org/2542883004
==========

to

==========
Bottom browser controls position based on window height

This change has the browser controls depend on the window viewport
rather than the visible viewport when drawing. This allows for the
math to be consistent across layouts that use the controls and
fixes the toolbar swipe layout.

To facilitate this, the SceneOverlay interface was updated to
include the window and visible viewports when updating their
respective SceneLayers.

BUG=652892

Committed: https://crrev.com/db62741d2a98508eae38f71a1e24672d66eda2f9
Cr-Commit-Position: refs/heads/master@{#437584}
==========

[commit-bot: I haz the power, 2016-12-12 14:36:09]

Patchset 3 (id:??) landed as
https://crrev.com/db62741d2a98508eae38f71a1e24672d66eda2f9
Cr-Commit-Position: refs/heads/master@{#437584}