Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1964)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java

Issue 2542883004: Bottom browser controls position based on window height (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java
index 6979658884d838fb32eff88c5541938f46a7bd54..5c8b9244a90c51ecaf94bdae193defb9b91f11c5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.browser.compositor.overlays;
+import android.graphics.RectF;
+
import org.chromium.chrome.browser.compositor.LayerTitleCache;
import org.chromium.chrome.browser.compositor.layouts.components.VirtualView;
import org.chromium.chrome.browser.compositor.layouts.eventfilter.EventFilter;
@@ -20,14 +22,16 @@ public interface SceneOverlay {
/**
* Updates and gets a {@link SceneOverlayLayer} that represents an scene overlay.
*
+ * @param viewport The viewport of the window.
+ * @param visibleViewport The viewport accounting for browser controls.
* @param layerTitleCache A layer title cache.
* @param resourceManager A resource manager.
* @param yOffset Current browser controls offset in dp.
* @return A {@link SceneOverlayLayer} that represents an scene overlay.
* Or {@code null} if this {@link SceneOverlay} doesn't have a tree.
*/
- SceneOverlayLayer getUpdatedSceneOverlayTree(LayerTitleCache layerTitleCache,
- ResourceManager resourceManager, float yOffset);
+ SceneOverlayLayer getUpdatedSceneOverlayTree(RectF viewport, RectF visibleViewport,
+ LayerTitleCache layerTitleCache, ResourceManager resourceManager, float yOffset);
/**
* Notify the layout that a SceneOverlay is visible. If not visible, the content tree will not

Powered by Google App Engine
This is Rietveld 408576698