chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java - Issue 2542883004: Bottom browser controls position based on window height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Issue 2542883004: Bottom browser controls position based on window height (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

index 26ca4c4c44286f94f1961e86f5829f9730862d8b..e284130af3ad6c0436f8f56f9c054ef8f50c3df8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.compositor.bottombar;

import android.app.Activity;

import android.content.Context;

+import android.graphics.RectF;

import org.chromium.base.ActivityState;

import org.chromium.base.ApplicationStatus;

@@ -765,8 +766,8 @@ public class OverlayPanel extends OverlayPanelAnimation implements ActivityState

// ============================================================================================

@Override

- public SceneOverlayLayer getUpdatedSceneOverlayTree(LayerTitleCache layerTitleCache,

- ResourceManager resourceManager, float yOffset) {

+ public SceneOverlayLayer getUpdatedSceneOverlayTree(RectF viewport, RectF visibleViewport,

+ LayerTitleCache layerTitleCache, ResourceManager resourceManager, float yOffset) {

return null;

}