Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2542173002: [Mac] Omnibox icons active states (Closed)

Created:
4 years ago by spqchan
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Mac] Omnibox icons active states Implemented OmniboxIconBubbleController for bubbles anchored to the omnibox icons. This controller updates the icon's active state based on the state of the bubble. This CL affect the following bubbles: - Translate - Permission - Content settings - Bookmarks - Manage passwords Other bubbles will be update in a follow up CL BUG=588377, 667707 Review-Url: https://codereview.chromium.org/2511043002 Cr-Commit-Position: refs/heads/master@{#435370} (cherry picked from commit 90af6b8cabfe002784be9735e4a1b675588b06f2) Committed: https://chromium.googlesource.com/chromium/src/+/44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -98 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 3 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 6 chunks +18 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h View 5 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm View 4 chunks +25 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 2 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +14 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.h View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.mm View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm View 2 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
4 years ago (2016-12-01 18:58:30 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
44cfc739a298fc9fa3193eac0cc9ae0a9fd9c980.

Powered by Google App Engine
This is Rietveld 408576698