Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 2542173002: [Mac] Omnibox icons active states (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index 109c410ee85b767c2b989d9dd73bd29ac3b09c28..581610865a5ec35042e4f47226f35a80df0036d1 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -418,30 +418,20 @@ bool LocationBarViewMac::IsStarEnabled() const {
!IsBookmarkStarHiddenByExtension();
}
-NSPoint LocationBarViewMac::GetBookmarkBubblePoint() const {
- DCHECK(IsStarEnabled());
- return [field_ bubblePointForDecoration:star_decoration_.get()];
+NSPoint LocationBarViewMac::GetBubblePointForDecoration(
+ LocationBarDecoration* decoration) const {
+ if (decoration == star_decoration_.get())
+ DCHECK(IsStarEnabled());
+
+ return [field_ bubblePointForDecoration:decoration];
}
NSPoint LocationBarViewMac::GetSaveCreditCardBubblePoint() const {
return [field_ bubblePointForDecoration:save_credit_card_decoration_.get()];
}
-NSPoint LocationBarViewMac::GetTranslateBubblePoint() const {
- return [field_ bubblePointForDecoration:translate_decoration_.get()];
-}
-
-NSPoint LocationBarViewMac::GetManagePasswordsBubblePoint() const {
- return [field_ bubblePointForDecoration:manage_passwords_decoration_.get()];
-}
-
NSPoint LocationBarViewMac::GetPageInfoBubblePoint() const {
- if (security_state_bubble_decoration_->IsVisible()) {
- return [field_
- bubblePointForDecoration:security_state_bubble_decoration_.get()];
- } else {
- return [field_ bubblePointForDecoration:location_icon_decoration_.get()];
- }
+ return [field_ bubblePointForDecoration:GetPageInfoDecoration()];
}
void LocationBarViewMac::OnDecorationsChanged() {
@@ -725,6 +715,13 @@ bool LocationBarViewMac::IsLocationBarDark() const {
return [[field_ window] inIncognitoModeWithSystemTheme];
}
+LocationBarDecoration* LocationBarViewMac::GetPageInfoDecoration() const {
+ if (security_state_bubble_decoration_->IsVisible())
+ return security_state_bubble_decoration_.get();
+
+ return location_icon_decoration_.get();
+}
+
NSImage* LocationBarViewMac::GetKeywordImage(const base::string16& keyword) {
const TemplateURL* template_url = TemplateURLServiceFactory::GetForProfile(
profile())->GetTemplateURLForKeyword(keyword);

Powered by Google App Engine
This is Rietveld 408576698