chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm - Issue 2542173002: [Mac] Omnibox icons active states

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm

Issue 2542173002: [Mac] Omnibox icons active states (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm ('k') | chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm

index cf412816ee24d8b2464a6af8977c16a7152fec73..ffe275c592412392c5c66df2b74b8926288e4331 100644

--- a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm

+++ b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm

@@ -55,11 +55,12 @@ ContentSettingBubbleControllerTest::CreateBubbleController(

[parent_ setReleasedWhenClosed:NO];

[parent_ orderFront:nil];

- ContentSettingBubbleController* controller = [ContentSettingBubbleController

- showForModel:bubble

- webContents:web_contents()

- parentWindow:parent_

- anchoredAt:NSMakePoint(50, 20)];

+ ContentSettingBubbleController* controller =

+ [ContentSettingBubbleController showForModel:bubble

+ webContents:web_contents()

+ parentWindow:parent_

+ decoration:nullptr

+ anchoredAt:NSMakePoint(50, 20)];

EXPECT_TRUE(controller);

EXPECT_TRUE([[controller window] isVisible]);