chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm - Issue 2542173002: [Mac] Omnibox icons active states

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Issue 2542173002: [Mac] Omnibox icons active states (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm ('k') | chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm b/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

index f092a09b85d4cd01b2cadc459d961dbdfc7e60bf..23824147629976fddb5a0816a2b0d5b6d6e242db 100644

--- a/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

@@ -228,7 +228,7 @@ void SecurityStateBubbleDecoration::DrawInFrame(NSRect frame,

[text drawInRect:text_rect];

// Draw the divider.

- if (state() == LocationBarDecorationState::NORMAL) {

+ if (state() == DecorationMouseState::NONE && !active()) {

NSBezierPath* line = [NSBezierPath bezierPath];

[line setLineWidth:line_width];

[line moveToPoint:NSMakePoint(NSMaxX(decoration_frame) - DividerPadding(),