Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2541583002: [Mac] Don't flip window controls in RTL for macOS < 10.12 (Closed)

Created:
4 years ago by lgrey
Modified:
4 years ago
CC:
chromium-reviews, jshin+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Don't flip window controls in RTL for macOS < 10.12 10.12 is the first macOS to flip the native window controls in RTL. This change restricts flipping to 10.12+ so we don't stick out. BUG=651674, 648559 Committed: https://crrev.com/49cb4c5017d1a34cf8cd126d3716c4f07c130c35 Cr-Commit-Position: refs/heads/master@{#435305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M chrome/browser/ui/cocoa/browser_window_layout.mm View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/l10n_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/l10n_util.mm View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
lgrey
PTAL :)
4 years ago (2016-11-29 17:59:52 UTC) #7
Elly Fong-Jones
lgtm lgtm :)
4 years ago (2016-11-29 22:46:54 UTC) #8
lgrey
Thanks! Avi PTAL for Mac OWNERS :)
4 years ago (2016-11-30 15:07:51 UTC) #10
Avi (use Gerrit)
lgtm RTL! 👍
4 years ago (2016-11-30 17:05:06 UTC) #11
lgrey
Thanks!
4 years ago (2016-11-30 17:08:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541583002/1
4 years ago (2016-11-30 17:09:01 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 17:20:06 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-30 17:22:22 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49cb4c5017d1a34cf8cd126d3716c4f07c130c35
Cr-Commit-Position: refs/heads/master@{#435305}

Powered by Google App Engine
This is Rietveld 408576698