Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chrome/browser/ui/cocoa/l10n_util.h

Issue 2541583002: [Mac] Don't flip window controls in RTL for macOS < 10.12 (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/framed_browser_window.mm ('k') | chrome/browser/ui/cocoa/l10n_util.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 #include <stddef.h> 6 #include <stddef.h>
7 7
8 #include "base/feature_list.h" 8 #include "base/feature_list.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 10
(...skipping 25 matching lines...) Expand all
36 36
37 extern const base::Feature kExperimentalMacRTL; 37 extern const base::Feature kExperimentalMacRTL;
38 // Returns whether both: 38 // Returns whether both:
39 // 1) Experimental Mac RTL support is enabled via the ExperimentalMacRTL 39 // 1) Experimental Mac RTL support is enabled via the ExperimentalMacRTL
40 // feature; 40 // feature;
41 // 2) The browser UI is in RTL mode. 41 // 2) The browser UI is in RTL mode.
42 // If ExperimentalMacRTL becomes the default, this function can be replaced with 42 // If ExperimentalMacRTL becomes the default, this function can be replaced with
43 // uses of base::i18n::IsRTL(). 43 // uses of base::i18n::IsRTL().
44 bool ShouldDoExperimentalRTLLayout(); 44 bool ShouldDoExperimentalRTLLayout();
45 45
46 // Returns true if ShouldDoExperimentalRTLLayout() is true and the OS is
47 // 10.12 or above. macOS 10.12 is the first OS where the native stoplight
48 // buttons are reversed in RTL, so manually reversing them in previous
49 // OSes would make Chrome stick out.
50 bool ShouldFlipWindowControlsInRTL();
51
46 } // namespace cocoa_l10n_util 52 } // namespace cocoa_l10n_util
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/framed_browser_window.mm ('k') | chrome/browser/ui/cocoa/l10n_util.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698