[Mac] Don't flip window controls in RTL for macOS < 10.12

chrome/browser/ui/cocoa/framed_browser_window.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/framed_browser_window.h"
 
 #include <math.h>
 #include <objc/runtime.h>
 #include <stddef.h>
 
@@ skipping 40 matching lines @@
 const CGFloat kWindowGradientHeight = 24.0;
 
 }
 
 @interface FramedBrowserWindow (Private)
 
 // Updates the title bar's frame so it moves the windows buttons to correct
 // location (frame bottom is moved down so the buttons are moved down as well).
 - (void)adjustTitlebarContainer:(NSView*)titlebarContainer;
 // Adds layout constraints to window buttons, respecting flag returned by
-// |ShouldDoExperimentalRTLLayout| method.
+// |ShouldFlipWindowControlsInRTL| method.
 - (void)setWindowButtonsConstraints;
 // Replaces -[NSThemeFrame addTrackingArea:] with implementation that ignores
 // tracking rect if its size is the same as the size of window buttons rect
 // (rect where close, miniaturize and zoom buttons are located). This is
 // needed to workaround macOS bug (rdar://28535344) which unnecessarily adds
 // window buttons tracking rect even if those buttons were moved.
 // TODO(crbug.com/651287): Remove this workaround once macOS bug is fixed.
 - (void)forbidAddingWindowButtonsTrackingArea;
 // Called when titlebar container changes its frame. This method adjusts
 // titlebar container with correct frame.
 - (void)titlebarDidChangeFrameNotification:(NSNotification*)notification;
 // Adds layout constraints to the given window button so it displayed at correct
-// location. This respects flag returned by |ShouldDoExperimentalRTLLayout|
+// location. This respects flag returned by |ShouldFlipWindowControlsInRTL|
 // method.
 - (void)setLeadingOffset:(CGFloat)leadingOffset
                 toButton:(NSWindowButton)buttonType;
 
 - (void)adjustCloseButton:(NSNotification*)notification;
 - (void)adjustMiniaturizeButton:(NSNotification*)notification;
 - (void)adjustZoomButton:(NSNotification*)notification;
 - (void)adjustButton:(NSButton*)button
               ofKind:(NSWindowButton)kind;
 - (void)childWindowsDidChange;
@@ skipping 179 matching lines @@
   [self adjustTitlebarContainer:[notification object]];
 }
 
 - (void)setLeadingOffset:(CGFloat)leadingOffset
                 toButton:(NSWindowButton)buttonType {
   DCHECK(chrome::ShouldUseFullSizeContentView());
 
   NSButton* button = [self standardWindowButton:buttonType];
   [button setTranslatesAutoresizingMaskIntoConstraints:NO];
 
-  // Do not use leadingAnchor because |ShouldDoExperimentalRTLLayout|
+  // Do not use leadingAnchor because |ShouldFlipWindowControlsInRTL|
   // should determine if current locale is RTL.
   NSLayoutXAxisAnchor* leadingSourceAnchor = [button leftAnchor];
   NSLayoutXAxisAnchor* leadingTargetAnchor = [[button superview] leftAnchor];
-  if (cocoa_l10n_util::ShouldDoExperimentalRTLLayout()) {
+  if (cocoa_l10n_util::ShouldFlipWindowControlsInRTL()) {
     leadingSourceAnchor = [button rightAnchor];
     leadingTargetAnchor = [[button superview] rightAnchor];
     leadingOffset = -leadingOffset;
   }
 
 #if !defined(MAC_OS_X_VERSION_10_11) || \
     MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_11
   id leadingSourceAnchorDuck = leadingSourceAnchor;
 #else
   NSLayoutXAxisAnchor* leadingSourceAnchorDuck = leadingSourceAnchor;
@@ skipping 42 matching lines @@
       buttonFrame.origin.x += windowButtonsInterButtonSpacing_;
       // fallthrough
     case NSWindowMiniaturizeButton:
       buttonFrame.origin.x += NSWidth([closeButton_ frame]);
       buttonFrame.origin.x += windowButtonsInterButtonSpacing_;
       // fallthrough
     default:
       break;
   }
 
-  if (cocoa_l10n_util::ShouldDoExperimentalRTLLayout()) {
+  if (cocoa_l10n_util::ShouldFlipWindowControlsInRTL()) {
     buttonFrame.origin.x =
         NSWidth([self frame]) - buttonFrame.origin.x - NSWidth([button frame]);
   }
 
   BOOL didPost = [button postsBoundsChangedNotifications];
   [button setPostsFrameChangedNotifications:NO];
   [button setFrame:buttonFrame];
   [button setPostsFrameChangedNotifications:didPost];
 }
 
@@ skipping 173 matching lines @@
   [self childWindowsDidChange];
 }
 
 - (void)childWindowsDidChange {
   id delegate = [self delegate];
   if ([delegate respondsToSelector:@selector(childWindowsDidChange)])
     [delegate childWindowsDidChange];
 }
 
 @end