chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm - Issue 2541583002: [Mac] Don't flip window controls in RTL for macOS < 10.12

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

Issue 2541583002: [Mac] Don't flip window controls in RTL for macOS < 10.12 (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

index 7f5576cf15c776157709aa41c64e819e67b83cea..3d8710d44f4dccf8ba35afb1b2f9afd019ff0189 100644

--- a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

@@ -159,7 +159,7 @@ bool ProfileUpdateObserver::HasAvatarError() {

// The new avatar bubble does not have an arrow, and it should be anchored

// to the edge of the avatar button.

- int anchorX = cocoa_l10n_util::ShouldDoExperimentalRTLLayout()

+ int anchorX = cocoa_l10n_util::ShouldFlipWindowControlsInRTL()

? NSMinX([anchor bounds]) + kMenuXOffsetAdjust

: NSMaxX([anchor bounds]) - kMenuXOffsetAdjust;

NSPoint point = NSMakePoint(anchorX,