Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: Source/core/html/MediaDocument.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/MediaDocument.cpp
diff --git a/Source/core/html/MediaDocument.cpp b/Source/core/html/MediaDocument.cpp
index e5b69677343b15300b6c77013c3d5a00135d203f..b4d2d1d0d7ad89d1ddb705c49309151fad86f199 100644
--- a/Source/core/html/MediaDocument.cpp
+++ b/Source/core/html/MediaDocument.cpp
@@ -66,7 +66,8 @@ private:
void createDocumentStructure();
- // FIXME(oilpan): We cannot handlify this until we move DocumentParser to the heap.
+ // FIXME(oilpan): This is a strong pointer.
zerny-chromium 2013/10/01 10:18:37 I'll fix this in a follow-up CL after moving over
+ // We cannot handlify this until we move DocumentParser to the heap.
// Note that Document (which might exist in the same tree of this HTMLMediaElement)
// has a Persistent handle to DocumentParser.
HTMLMediaElement* m_mediaElement;

Powered by Google App Engine
This is Rietveld 408576698