Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index ea820414be4546ee8ea342a0405409b95104aab2..ca71be12ce56ae2adb59cb3d28919f6be03d8ba9 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -98,7 +98,7 @@ public:
private:
ListAttributeTargetObserver(const AtomicString& id, const Handle<HTMLInputElement>&);
- // FIXME(oilpan): Move ListAttributeTargetObserver to the heap and use a Member.
+ // FIXME(oilpan): This should be a strong pointer.
zerny-chromium 2013/10/01 10:18:37 Just to be sure: we want a weak pointer from the r
haraken 2013/10/01 16:46:52 Yes, updated the comment to clarify that.
HTMLInputElement* m_element;
};
#endif

Powered by Google App Engine
This is Rietveld 408576698