Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Side by Side Diff: Source/core/html/MediaDocument.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 MediaDocumentParser(const Handle<Document>& document) 59 MediaDocumentParser(const Handle<Document>& document)
60 : RawDataDocumentParser(document) 60 : RawDataDocumentParser(document)
61 , m_mediaElement(0) 61 , m_mediaElement(0)
62 { 62 {
63 } 63 }
64 64
65 virtual void appendBytes(DocumentWriter*, const char*, size_t); 65 virtual void appendBytes(DocumentWriter*, const char*, size_t);
66 66
67 void createDocumentStructure(); 67 void createDocumentStructure();
68 68
69 // FIXME(oilpan): We cannot handlify this until we move DocumentParser to th e heap. 69 // FIXME(oilpan): This is a strong pointer.
zerny-chromium 2013/10/01 10:18:37 I'll fix this in a follow-up CL after moving over
70 // We cannot handlify this until we move DocumentParser to the heap.
70 // Note that Document (which might exist in the same tree of this HTMLMediaE lement) 71 // Note that Document (which might exist in the same tree of this HTMLMediaE lement)
71 // has a Persistent handle to DocumentParser. 72 // has a Persistent handle to DocumentParser.
72 HTMLMediaElement* m_mediaElement; 73 HTMLMediaElement* m_mediaElement;
73 }; 74 };
74 75
75 void MediaDocumentParser::createDocumentStructure() 76 void MediaDocumentParser::createDocumentStructure()
76 { 77 {
77 Handle<Element> rootElement = document()->createElement(htmlTag, false); 78 Handle<Element> rootElement = document()->createElement(htmlTag, false);
78 document()->appendChild(rootElement, IGNORE_EXCEPTION); 79 document()->appendChild(rootElement, IGNORE_EXCEPTION);
79 document()->setCSSTarget(rootElement); 80 document()->setCSSTarget(rootElement);
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 videoElement->parentNode()->replaceChild(embedElement, videoElement, IGN ORE_EXCEPTION); 225 videoElement->parentNode()->replaceChild(embedElement, videoElement, IGN ORE_EXCEPTION);
225 } 226 }
226 } 227 }
227 228
228 void MediaDocument::accept(Visitor* visitor) const 229 void MediaDocument::accept(Visitor* visitor) const
229 { 230 {
230 HTMLDocument::accept(visitor); 231 HTMLDocument::accept(visitor);
231 } 232 }
232 233
233 } 234 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698