Source/core/html/InputType.h - Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/InputType.h

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/InputType.h

diff --git a/Source/core/html/InputType.h b/Source/core/html/InputType.h

index 164af601d46b84d0b5580edb5b4053af86f253ef..0693bb60471c5f2e2cd8e533b958f1a1326172f5 100644

--- a/Source/core/html/InputType.h

+++ b/Source/core/html/InputType.h

@@ -317,7 +317,7 @@ private:

// Helper for stepUp()/stepDown(). Adds step value * count to the current value.

void applyStep(int count, AnyStepHandling, TextFieldEventBehavior, ExceptionCode&);

- // FIXME(oilpan): Move ClickHandlingState to the heap and use a Member.

+ // FIXME(oilpan): This should be a strong pointer.

HTMLInputElement* m_element;

};

« Source/core/html/HTMLInputElement.cpp ('K') | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/MediaDocument.cpp » ('j') | Source/core/html/MediaDocument.cpp » ('J')