Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 #if ENABLE(DATALIST_ELEMENT) 91 #if ENABLE(DATALIST_ELEMENT)
92 class ListAttributeTargetObserver : public IdTargetObserver { 92 class ListAttributeTargetObserver : public IdTargetObserver {
93 WTF_MAKE_FAST_ALLOCATED; 93 WTF_MAKE_FAST_ALLOCATED;
94 public: 94 public:
95 static PassOwnPtr<ListAttributeTargetObserver> create(const AtomicString& id , const Handle<HTMLInputElement>&); 95 static PassOwnPtr<ListAttributeTargetObserver> create(const AtomicString& id , const Handle<HTMLInputElement>&);
96 virtual void idTargetChanged() OVERRIDE; 96 virtual void idTargetChanged() OVERRIDE;
97 97
98 private: 98 private:
99 ListAttributeTargetObserver(const AtomicString& id, const Handle<HTMLInputEl ement>&); 99 ListAttributeTargetObserver(const AtomicString& id, const Handle<HTMLInputEl ement>&);
100 100
101 // FIXME(oilpan): Move ListAttributeTargetObserver to the heap and use a Mem ber. 101 // FIXME(oilpan): This should be a strong pointer.
zerny-chromium 2013/10/01 10:18:37 Just to be sure: we want a weak pointer from the r
haraken 2013/10/01 16:46:52 Yes, updated the comment to clarify that.
102 HTMLInputElement* m_element; 102 HTMLInputElement* m_element;
103 }; 103 };
104 #endif 104 #endif
105 105
106 // FIXME: According to HTML4, the length attribute's value can be arbitrarily 106 // FIXME: According to HTML4, the length attribute's value can be arbitrarily
107 // large. However, due to https://bugs.webkit.org/show_bug.cgi?id=14536 things 107 // large. However, due to https://bugs.webkit.org/show_bug.cgi?id=14536 things
108 // get rather sluggish when a text field has a larger number of characters than 108 // get rather sluggish when a text field has a larger number of characters than
109 // this, even when just clicking in the text field. 109 // this, even when just clicking in the text field.
110 const int HTMLInputElement::maximumLength = 524288; 110 const int HTMLInputElement::maximumLength = 524288;
111 const int defaultSize = 20; 111 const int defaultSize = 20;
(...skipping 1786 matching lines...) Expand 10 before | Expand all | Expand 10 after
1898 return m_inputType->customStyleForRenderer(document()->styleResolver()->styl eForElement(selfHandle())); 1898 return m_inputType->customStyleForRenderer(document()->styleResolver()->styl eForElement(selfHandle()));
1899 } 1899 }
1900 #endif 1900 #endif
1901 1901
1902 void HTMLInputElement::accept(Visitor* visitor) const 1902 void HTMLInputElement::accept(Visitor* visitor) const
1903 { 1903 {
1904 HTMLTextFormControlElement::accept(visitor); 1904 HTMLTextFormControlElement::accept(visitor);
1905 } 1905 }
1906 1906
1907 } // namespace 1907 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698