Issue 2539673003: Mac: Convert all the TabDialogs to Harmony

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2539673003: Mac: Convert all the TabDialogs to Harmony (Closed)

Created:
4 years ago by tapted

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mac-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mac: Convert all the TabDialogs to Harmony cl format Progress - now duplicate symbols ** need to fix: duplicate symbol __ZN28SigninViewControllerDelegate25CreateSigninErrorDelegateEP20SigninViewControllerP7Browser in: obj/chrome/browser/ui/libui.a(signin_view_controller_delegate_mac.o) obj/chrome/browser/ui/libui.a(signin_view_controller_delegate_views.o) duplicate symbol __ZN28SigninViewControllerDelegate30CreateSyncConfirmationDelegateEP20SigninViewControllerP7Browser in: obj/chrome/browser/ui/libui.a(signin_view_controller_delegate_mac.o) obj/chrome/browser/ui/libui.a(signin_view_controller_delegate_views.o) duplicate symbol __ZN28SigninViewControllerDelegate25CreateModalSigninDelegateEP20SigninViewControllerN8profiles14BubbleViewModeEP7BrowserN14signin_metrics11AccessPointE in: obj/chrome/browser/ui/libui.a(signin_view_controller_delegate_mac.o) obj/chrome/browser/ui/libui.a(signin_view_controller_delegate_views.o) Opt collected cookies into DialogBrowserTest sort ehaders Progress Pretty close? Progress - patch for duplicate object file BUG=669387, 662128

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -53 lines)			Patch
M	chrome/browser/collected_cookies_browsertest.cc	View	1 chunk	+30 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/BUILD.gn	View	9 chunks	+28 lines, -23 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tab_dialogs_cocoa.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm	View	1 chunk	+8 lines, -2 lines	0 comments	Download
A	chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm	View	1 chunk	+48 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc	View	6 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/tab_dialogs_views.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2536733005 Patch 1