Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2539673003: Mac: Convert all the TabDialogs to Harmony (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/collected_cookies_browsertest.cc ('k') | chrome/browser/ui/cocoa/tab_dialogs_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 818f53d1ffebf31b5ed6cd8110bbff1a99dc5b7a..2ea60a5f5c88cc8275aec9970747cdf2d251feb4 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -1493,6 +1493,8 @@ split_static_library("ui") {
"views/harmony/harmony_layout_delegate.h",
"views/harmony/layout_delegate.cc",
"views/harmony/layout_delegate.h",
+ "views/hung_renderer_view.cc",
+ "views/hung_renderer_view.h",
"views/layout_utils.cc",
"views/layout_utils.h",
"views/location_bar/location_bar_bubble_delegate_view.cc",
@@ -1502,12 +1504,28 @@ split_static_library("ui") {
"views/login_view.h",
"views/new_back_shortcut_bubble.cc",
"views/new_back_shortcut_bubble.h",
+ "views/passwords/credentials_item_view.cc",
+ "views/passwords/credentials_item_view.h",
+ "views/passwords/credentials_selection_view.cc",
+ "views/passwords/credentials_selection_view.h",
+ "views/passwords/manage_password_items_view.cc",
+ "views/passwords/manage_password_items_view.h",
+ "views/passwords/manage_passwords_bubble_view.cc",
+ "views/passwords/manage_passwords_bubble_view.h",
+ "views/passwords/manage_passwords_icon_views.cc",
+ "views/passwords/manage_passwords_icon_views.h",
+ "views/profiles/signin_view_controller_delegate_views.cc",
+ "views/profiles/signin_view_controller_delegate_views.h",
"views/subtle_notification_view.cc",
"views/subtle_notification_view.h",
"views/sync/bubble_sync_promo_view.cc",
"views/sync/bubble_sync_promo_view.h",
+ "views/tab_dialogs_views.cc",
+ "views/tab_dialogs_views.h",
"views/task_manager_view.cc",
"views/task_manager_view.h",
+ "views/validation_message_bubble_view.cc",
+ "views/validation_message_bubble_view.h",
"views/website_settings/chosen_object_row.cc",
"views/website_settings/chosen_object_row.h",
"views/website_settings/chosen_object_row_observer.h",
@@ -1537,7 +1555,15 @@ split_static_library("ui") {
"views/apps/app_info_dialog/arc_app_info_links_panel.cc",
"views/apps/app_info_dialog/arc_app_info_links_panel.h",
]
- } else if (!is_mac || mac_views_browser) {
+ } else {
+ sources += [
+ "views/profiles/profile_chooser_view.cc",
+ "views/profiles/profile_chooser_view.h",
+ "views/sync/profile_signin_confirmation_dialog_views.cc",
+ "views/sync/profile_signin_confirmation_dialog_views.h",
+ ]
+ }
+ if (!is_chromeos && (!is_mac || mac_views_browser)) {
sources += [
"external_protocol_dialog_delegate.cc",
"external_protocol_dialog_delegate.h",
@@ -1552,13 +1578,9 @@ split_static_library("ui") {
"views/frame/opaque_browser_frame_view_linux.h",
"views/frame/opaque_browser_frame_view_platform_specific.cc",
"views/frame/opaque_browser_frame_view_platform_specific.h",
- "views/profiles/profile_chooser_view.cc",
- "views/profiles/profile_chooser_view.h",
"views/screen_capture_notification_ui_views.cc",
"views/sync/one_click_signin_dialog_view.cc",
"views/sync/one_click_signin_dialog_view.h",
- "views/sync/profile_signin_confirmation_dialog_views.cc",
- "views/sync/profile_signin_confirmation_dialog_views.h",
]
}
@@ -1720,8 +1742,6 @@ split_static_library("ui") {
"views/frame/web_contents_close_handler_delegate.h",
"views/global_error_bubble_view.cc",
"views/global_error_bubble_view.h",
- "views/hung_renderer_view.cc",
- "views/hung_renderer_view.h",
"views/ime/ime_warning_bubble_view.cc",
"views/ime/ime_warning_bubble_view.h",
"views/importer/import_lock_dialog_view.cc",
@@ -1784,21 +1804,9 @@ split_static_library("ui") {
"views/passwords/account_chooser_dialog_view.h",
"views/passwords/auto_signin_first_run_dialog_view.cc",
"views/passwords/auto_signin_first_run_dialog_view.h",
- "views/passwords/credentials_item_view.cc",
- "views/passwords/credentials_item_view.h",
- "views/passwords/credentials_selection_view.cc",
- "views/passwords/credentials_selection_view.h",
- "views/passwords/manage_password_items_view.cc",
- "views/passwords/manage_password_items_view.h",
- "views/passwords/manage_passwords_bubble_view.cc",
- "views/passwords/manage_passwords_bubble_view.h",
- "views/passwords/manage_passwords_icon_views.cc",
- "views/passwords/manage_passwords_icon_views.h",
"views/process_singleton_dialog_linux.cc",
"views/profiles/profile_indicator_icon.cc",
"views/profiles/profile_indicator_icon.h",
- "views/profiles/signin_view_controller_delegate_views.cc",
- "views/profiles/signin_view_controller_delegate_views.h",
"views/profiles/user_manager_view.cc",
"views/profiles/user_manager_view.h",
"views/proximity_auth/proximity_auth_error_bubble_view.cc",
@@ -1818,8 +1826,6 @@ split_static_library("ui") {
"views/status_icons/status_tray_state_changer_win.h",
"views/status_icons/status_tray_win.cc",
"views/status_icons/status_tray_win.h",
- "views/tab_dialogs_views.cc",
- "views/tab_dialogs_views.h",
"views/tab_icon_view.cc",
"views/tab_icon_view.h",
"views/tab_modal_confirm_dialog_views.cc",
@@ -1877,8 +1883,6 @@ split_static_library("ui") {
"views/translate/translate_icon_view.h",
"views/update_recommended_message_box.cc",
"views/update_recommended_message_box.h",
- "views/validation_message_bubble_view.cc",
- "views/validation_message_bubble_view.h",
"views/website_settings/chooser_bubble_ui_view.cc",
"views/website_settings/chooser_bubble_ui_view.h",
"views/website_settings/permission_prompt_impl_views.cc",
@@ -2886,6 +2890,7 @@ split_static_library("ui") {
"cocoa/tab_contents/tab_contents_controller.mm",
"cocoa/tab_dialogs_cocoa.h",
"cocoa/tab_dialogs_cocoa.mm",
+ "cocoa/tab_dialogs_views_mac.mm",
"cocoa/tab_modal_confirm_dialog_mac.h",
"cocoa/tab_modal_confirm_dialog_mac.mm",
"cocoa/tabs/alert_indicator_button_cocoa.h",
« no previous file with comments | « chrome/browser/collected_cookies_browsertest.cc ('k') | chrome/browser/ui/cocoa/tab_dialogs_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698