Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4840)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 2539673003: Mac: Convert all the TabDialogs to Harmony (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm ('k') | chrome/browser/ui/views/tab_dialogs_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 6ea354c7b80c567faa40a7528e05b4d745fb0fd3..49deaff1abaa0ad236dc2b68d7dd19ee0e05b912 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -227,6 +227,7 @@ ManagePasswordsBubbleView::AutoSigninView::AutoSigninView(
credential->SetEnabled(false);
AddChildView(credential);
+#if 0
// Setup the observer and maybe start the timer.
Browser* browser =
chrome::FindBrowserWithWebContents(parent_->web_contents());
@@ -236,6 +237,7 @@ ManagePasswordsBubbleView::AutoSigninView::AutoSigninView(
if (browser_view->IsActive())
timer_.Start(FROM_HERE, GetTimeout(), this, &AutoSigninView::OnTimer);
+#endif
}
void ManagePasswordsBubbleView::AutoSigninView::ButtonPressed(
@@ -718,9 +720,10 @@ void ManagePasswordsBubbleView::ShowBubble(
DCHECK(!manage_passwords_bubble_ ||
!manage_passwords_bubble_->GetWidget()->IsVisible());
- BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
- bool is_fullscreen = browser_view->IsFullscreen();
views::View* anchor_view = nullptr;
+ bool is_fullscreen = browser->window()->IsFullscreen();
+#if 0
+ BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
if (!is_fullscreen) {
if (ui::MaterialDesignController::IsSecondaryUiMaterial()) {
anchor_view = browser_view->GetLocationBarView();
@@ -729,6 +732,7 @@ void ManagePasswordsBubbleView::ShowBubble(
browser_view->GetLocationBarView()->manage_passwords_icon_view();
}
}
+#endif
manage_passwords_bubble_ = new ManagePasswordsBubbleView(
web_contents, anchor_view, reason);
@@ -737,6 +741,8 @@ void ManagePasswordsBubbleView::ShowBubble(
views::Widget* manage_passwords_bubble_widget =
views::BubbleDialogDelegateView::CreateBubble(manage_passwords_bubble_);
+ ALLOW_UNUSED_LOCAL(manage_passwords_bubble_widget);
+#if 0
if (anchor_view) {
manage_passwords_bubble_widget->AddObserver(
browser_view->GetLocationBarView()->manage_passwords_icon_view());
@@ -747,6 +753,7 @@ void ManagePasswordsBubbleView::ShowBubble(
manage_passwords_bubble_->AdjustForFullscreen(
browser_view->GetBoundsInScreen());
}
+#endif
manage_passwords_bubble_->ShowForReason(reason);
}
« no previous file with comments | « chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm ('k') | chrome/browser/ui/views/tab_dialogs_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698