Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2536733005: Cocoa: Rename credentials_selection_view to credentials_selection_view_cocoa (Closed)

Created:
4 years ago by tapted
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cocoa: Rename credentials_selection_view to credentials_selection_view_cocoa There is also chrome/browser/ui/views/passwords/credentials_item_view.cc, so if we want to select one at runtime, we will get ERROR at //build/split_static_library.gni:12:5: Duplicate object file static_library(target_name) { ^---------------------------- The target //chrome/browser/ui:ui generates two object files with the same name: obj/chrome/browser/ui/ui/credentials_selection_view.o BUG=669387

Patch Set 1 #

Messages

Total messages: 8 (8 generated)
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years ago (2016-11-29 07:03:27 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536733005/1
4 years ago (2016-11-29 07:03:44 UTC) #2
tapted
Description was changed from ========== Rename BUG=662128 ========== to ========== Cocoa: Rename credentials_selection_view to credentials_selection_view_cocoa ...
4 years ago (2016-11-29 07:06:03 UTC) #3
tapted
tapted@chromium.org changed reviewers: + karandeepb@chromium.org
4 years ago (2016-11-29 07:06:03 UTC) #4
tapted
Description was changed from ========== Cocoa: Rename credentials_selection_view to credentials_selection_view_cocoa There is also chrome/browser/ui/views/passwords/credentials_item_view.cc, so ...
4 years ago (2016-11-29 07:27:43 UTC) #5
tapted
tapted@chromium.org changed reviewers: - karandeepb@chromium.org
4 years ago (2016-11-29 07:27:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-11-29 08:26:39 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 08:26:40 UTC) #8
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698