Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 25371003: Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone. (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
scroggo, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone. We're writing fDone without holding the mutex. Bad form, says tsan. In practice this is fairly innocuous, as fDone only ever goes from false to true and only once. Though, I wouldn't be surprised if there were some way this could leak a thread that never got the signal to die. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/utils/SkThreadPool.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkThreadPool.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
7 years, 2 months ago (2013-09-30 23:45:24 UTC) #1
scroggo
lgtm
7 years, 2 months ago (2013-10-01 15:21:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/25371003/1
7 years, 2 months ago (2013-10-01 15:24:53 UTC) #3
commit-bot: I haz the power
Presubmit check for 25371003-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 2 months ago (2013-10-01 15:24:56 UTC) #4
mtklein
Mike, can you approve my indentation?
7 years, 2 months ago (2013-10-01 15:25:42 UTC) #5
reed1
lgtm
7 years, 2 months ago (2013-10-01 15:27:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/25371003/1
7 years, 2 months ago (2013-10-01 15:27:43 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 18:44:36 UTC) #8
Message was sent while issue was closed.
Change committed as 11563

Powered by Google App Engine
This is Rietveld 408576698