include/utils/SkThreadPool.h - Issue 25371003: Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/utils/SkThreadPool.h

Issue 25371003: Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/utils/SkThreadPool.h

diff --git a/include/utils/SkThreadPool.h b/include/utils/SkThreadPool.h

index 3c8615809089a21d1076c62642f3ba4d9b218cd3..98657034e58bec72e90080df5800ccfed6a32612 100644

--- a/include/utils/SkThreadPool.h

+++ b/include/utils/SkThreadPool.h

@@ -43,7 +43,7 @@ public:

SkTInternalLList<LinkedRunnable> fQueue;

SkCondVar fReady;

SkTDArray<SkThread*> fThreads;

- bool fDone;

+ bool fDone;

static void Loop(void*); // Static because we pass in this.

};

« no previous file with comments | « no previous file | src/utils/SkThreadPool.cpp » ('j') | no next file with comments »