Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: include/utils/SkThreadPool.h

Issue 25371003: Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/utils/SkThreadPool.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkThreadPool_DEFINED 8 #ifndef SkThreadPool_DEFINED
9 #define SkThreadPool_DEFINED 9 #define SkThreadPool_DEFINED
10 10
(...skipping 25 matching lines...) Expand all
36 // Unowned pointer. 36 // Unowned pointer.
37 SkRunnable* fRunnable; 37 SkRunnable* fRunnable;
38 38
39 private: 39 private:
40 SK_DECLARE_INTERNAL_LLIST_INTERFACE(LinkedRunnable); 40 SK_DECLARE_INTERNAL_LLIST_INTERFACE(LinkedRunnable);
41 }; 41 };
42 42
43 SkTInternalLList<LinkedRunnable> fQueue; 43 SkTInternalLList<LinkedRunnable> fQueue;
44 SkCondVar fReady; 44 SkCondVar fReady;
45 SkTDArray<SkThread*> fThreads; 45 SkTDArray<SkThread*> fThreads;
46 bool fDone; 46 bool fDone;
47 47
48 static void Loop(void*); // Static because we pass in this. 48 static void Loop(void*); // Static because we pass in this.
49 }; 49 };
50 50
51 #endif 51 #endif
OLDNEW
« no previous file with comments | « no previous file | src/utils/SkThreadPool.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698