src/utils/SkThreadPool.cpp - Issue 25371003: Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkThreadPool.cpp

Issue 25371003: Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkThreadPool.cpp

diff --git a/src/utils/SkThreadPool.cpp b/src/utils/SkThreadPool.cpp

index 5fe10255b5ae599945cd4fa3c5051a35dcdb05f3..3d19d1c5b9f8a75dde1ab574f98fe6f7b61fd3eb 100644

--- a/src/utils/SkThreadPool.cpp

+++ b/src/utils/SkThreadPool.cpp

@@ -39,8 +39,8 @@ SkThreadPool::SkThreadPool(int count)

}

SkThreadPool::~SkThreadPool() {

- fDone = true;

fReady.lock();

+ fDone = true;

fReady.broadcast();

fReady.unlock();

« no previous file with comments | « include/utils/SkThreadPool.h ('k') | no next file » | no next file with comments »