Split Resource::Status into a separate file

Split Resource::Status into a separate file

This is to remove dependencies from ImageResourceInfo.h and
ImageResourceContent.h to Resource.h in
https://codereview.chromium.org/2469873002/.

BUG=667641
Committed: https://crrev.com/34706455e96a5644ad61a57fc6bc3e8864dc5b36
Cr-Commit-Position: refs/heads/master@{#437700}

[hiroshige, 2016-11-29 07:37:28]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 07:37:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 09:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 09:20:21]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-29 09:21:31]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 09:22:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 11:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 11:20:51]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-30 06:02:01]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 06:03:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 09:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 09:15:25]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-12-01 06:52:37]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 06:52:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 08:25:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 08:25:01]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-12-05 06:22:37]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 06:22:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-12-05 08:41:36]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 08:41:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 11:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 11:36:33]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-12-07 07:08:09]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 07:08:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-12-07 07:16:04]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, toyoshim@chromium.org, yhirano@chromium.org

[hiroshige, 2016-12-07 07:16:05]

PTAL.

This is to remove dependencies from ImageResourceInfo.h and
ImageResourceContent.h to Resource.h in [1].
I'm not sure whether removing the dependency is worth doing at the cost of an
additional header file this CL.
If it is fine with us to refer Resource::Status from ImageResourceInfo, then
I'll revert ResourceStatus back into Resource::Status in [1] and close this CL.

[1] https://codereview.chromium.org/2469873002/

[commit-bot: I haz the power, 2016-12-07 08:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 08:53:48]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-12-08 04:45:26]

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/Resource.cpp:304: constexpr
Resource::Status Resource::NotStarted;
I don't understand why these are needed. A static const[expr] member can be
initialized in the class definition and a separate definition is not needed in
such a case, right?

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/ResourceStatus.h (right):

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/ResourceStatus.h:2: Copyright (C) 1998 Lars
Knoll (knoll@mpi-hd.mpg.de)
Wrong license.

[hiroshige, 2016-12-08 10:07:39]

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/Resource.cpp:304: constexpr
Resource::Status Resource::NotStarted;
On 2016/12/08 04:45:26, yhirano wrote:
> I don't understand why these are needed. A static const[expr] member can be
> initialized in the class definition and a separate definition is not needed in
> such a case, right?

I also thought so but the compile failed on Linux if I remove these definitions.

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/ResourceStatus.h (right):

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/ResourceStatus.h:2: Copyright (C) 1998 Lars
Knoll (knoll@mpi-hd.mpg.de)
On 2016/12/08 04:45:26, yhirano wrote:
> Wrong license.

Done.

[hiroshige, 2016-12-09 06:57:31]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 06:57:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-12-09 07:20:38]

https://codereview.chromium.org/2537063002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/ResourceStatus.h (right):

https://codereview.chromium.org/2537063002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/ResourceStatus.h:11: NotStarted,
How about changing this to new kFooBar style together?

[hiroshige, 2016-12-09 07:52:39]

https://codereview.chromium.org/2537063002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/ResourceStatus.h (right):

https://codereview.chromium.org/2537063002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/ResourceStatus.h:11: NotStarted,
On 2016/12/09 07:20:38, toyoshim wrote:
> How about changing this to new kFooBar style together?

I think it's better to do it together with erasing/replacing
Resource::NotStarted etc. (to avoid having both ResourceStatus::kNotStarted and
Resource::NotStarted).
I'll leave a TODO.

[yhirano, 2016-12-09 08:40:05]

lgtm

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2537063002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/Resource.cpp:304: constexpr
Resource::Status Resource::NotStarted;
On 2016/12/08 10:07:39, hiroshige wrote:
> On 2016/12/08 04:45:26, yhirano wrote:
> > I don't understand why these are needed. A static const[expr] member can be
> > initialized in the class definition and a separate definition is not needed
in
> > such a case, right?
> 
> I also thought so but the compile failed on Linux if I remove these
definitions.

yutak@ told me that an "odr-used" variable should have a separate definition.
http://en.cppreference.com/w/cpp/language/definition#ODR-use

[Takashi Toyoshima, 2016-12-09 08:42:12]

lgtm

[commit-bot: I haz the power, 2016-12-09 08:51:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 08:51:40]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-12-09 23:02:23]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-12-09 23:02:32]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-12-09 23:03:29]

Description was changed from

==========
Split Resource::Status

BUG=
==========

to

==========
Split Resource::Status into a separate file

This is to remove dependencies from ImageResourceInfo.h and
ImageResourceContent.h to Resource.h in
https://codereview.chromium.org/2469873002/.

BUG=667641
==========

[hiroshige, 2016-12-09 23:03:34]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-12-09 23:04:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 23:43:30]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1481324614522320,
"parent_rev": "72c92d60b36db4834aace9a883f78046cfdd1855", "commit_rev":
"7a9c2b1eead989fa00034b8e9969d3708a35eb15"}

[commit-bot: I haz the power, 2016-12-09 23:43:55]

Description was changed from

==========
Split Resource::Status into a separate file

This is to remove dependencies from ImageResourceInfo.h and
ImageResourceContent.h to Resource.h in
https://codereview.chromium.org/2469873002/.

BUG=667641
==========

to

==========
Split Resource::Status into a separate file

This is to remove dependencies from ImageResourceInfo.h and
ImageResourceContent.h to Resource.h in
https://codereview.chromium.org/2469873002/.

BUG=667641

Review-Url: https://codereview.chromium.org/2537063002
==========

[commit-bot: I haz the power, 2016-12-09 23:43:56]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-12-12 14:58:41]

Description was changed from

==========
Split Resource::Status into a separate file

This is to remove dependencies from ImageResourceInfo.h and
ImageResourceContent.h to Resource.h in
https://codereview.chromium.org/2469873002/.

BUG=667641

Review-Url: https://codereview.chromium.org/2537063002
==========

to

==========
Split Resource::Status into a separate file

This is to remove dependencies from ImageResourceInfo.h and
ImageResourceContent.h to Resource.h in
https://codereview.chromium.org/2469873002/.

BUG=667641

Committed: https://crrev.com/34706455e96a5644ad61a57fc6bc3e8864dc5b36
Cr-Commit-Position: refs/heads/master@{#437700}
==========

[commit-bot: I haz the power, 2016-12-12 14:58:42]

Patchset 9 (id:??) landed as
https://crrev.com/34706455e96a5644ad61a57fc6bc3e8864dc5b36
Cr-Commit-Position: refs/heads/master@{#437700}