third_party/WebKit/Source/core/fetch/ResourceStatus.h - Issue 2537063002: Split Resource::Status into a separate file

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/fetch/ResourceStatus.h

Issue 2537063002: Split Resource::Status into a separate file (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef ResourceStatus_h

	6 #define ResourceStatus_h

	7

	8 namespace blink {

	9

	10 enum class ResourceStatus {

	11 NotStarted,
	Takashi Toyoshima 2016/12/09 07:20:38 How about changing this to new kFooBar style toget How about changing this to new kFooBar style together? hiroshige 2016/12/09 07:52:39 I think it's better to do it together with erasing Show quoted text On 2016/12/09 07:20:38, toyoshim wrote: > How about changing this to new kFooBar style together? I think it's better to do it together with erasing/replacing Resource::NotStarted etc. (to avoid having both ResourceStatus::kNotStarted and Resource::NotStarted). I'll leave a TODO.
	12 Pending, // load in progress

	13 Cached, // load completed successfully

	14 LoadError,

	15 DecodeError

	16 };

	17

	18 } // namespace blink

	19

	20 #endif

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/core/fetch/Resource.cpp ('k') | no next file » | no next file with comments »