Split Resource::Status into a separate file

third_party/WebKit/Source/core/fetch/Resource.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
     rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
@@ skipping 283 matching lines @@
 void Resource::ResourceCallback::runTask() {
   HeapVector<Member<Resource>> resources;
   for (const Member<Resource>& resource : m_resourcesWithPendingClients)
     resources.append(resource.get());
   m_resourcesWithPendingClients.clear();
 
   for (const auto& resource : resources)
     resource->finishPendingClients();
 }
 
+constexpr Resource::Status Resource::NotStarted;

[yhirano, 2016/12/08 04:45:26]

I don't understand why these are needed. A static const[expr] member can be
initialized in the class definition and a separate definition is not needed in
such a case, right?

[hiroshige, 2016/12/08 10:07:39]

I also thought so but the compile failed on Linux if I remove these definitions.

[yhirano, 2016/12/09 08:40:05]

yutak@ told me that an "odr-used" variable should have a separate definition.
http://en.cppreference.com/w/cpp/language/definition#ODR-use

+constexpr Resource::Status Resource::Pending;
+constexpr Resource::Status Resource::Cached;
+constexpr Resource::Status Resource::LoadError;
+constexpr Resource::Status Resource::DecodeError;
+
 Resource::Resource(const ResourceRequest& request,
                    Type type,
                    const ResourceLoaderOptions& options)
     : m_loadFinishTime(0),
       m_identifier(0),
       m_encodedSize(0),
       m_encodedSizeMemoryUsage(0),
       m_decodedSize(0),
       m_overheadSize(calculateOverheadSize()),
       m_preloadCount(0),
@@ skipping 785 matching lines @@
     case Resource::TextTrack:
     case Resource::Media:
     case Resource::Manifest:
       return false;
   }
   NOTREACHED();
   return false;
 }
 
 }  // namespace blink