Simplify: remove PendingScript::releaseElementAndClear

Simplify: remove PendingScript::releaseElementAndClear

Simplify PendingScript disposal path by removing method releaseElementAndClear.
Callers should use dispose() directly instead of repeating stopWatchingForLoad + releaseElementAndClear calls.

BUG=None

Committed: https://crrev.com/9ec9d9b469c760634b4d0126a2c369f3627ac8e9
Cr-Commit-Position: refs/heads/master@{#434897}

[kouhei (in TOK), 2016-11-28 09:17:05]

kouhei@chromium.org changed reviewers:
+ dominicc@chromium.org, yhirano@chromium.org

[kouhei (in TOK), 2016-11-28 09:17:06]

ptal

[kouhei (in TOK), 2016-11-28 09:17:10]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 09:17:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 09:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 09:30:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sof, 2016-11-28 16:17:59]

ScriptStreamerTest needs to be adjusted also.

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/PendingScript.cpp (right):

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/PendingScript.cpp:55: if (m_client)
stopWatchingForLoad() already checks for not being in a watching-a-load state,
just call it unconditionally?

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/PendingScript.cpp:60: m_watchingForLoad =
false;
This ought to be redundant now.

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp (right):

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp:211:
pendingScript->stopWatchingForLoad();
Can this call (effectively) be moved down to where the dispose() now is?

[kouhei (in TOK), 2016-11-29 00:29:48]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 00:30:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2016-11-29 00:49:05]

Thanks for the review!

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/PendingScript.cpp (right):

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/PendingScript.cpp:55: if (m_client)
On 2016/11/28 16:17:59, sof wrote:
> stopWatchingForLoad() already checks for not being in a watching-a-load state,
> just call it unconditionally?

Done.

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/PendingScript.cpp:60: m_watchingForLoad =
false;
On 2016/11/28 16:17:59, sof wrote:
> This ought to be redundant now.

Done.

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp (right):

https://codereview.chromium.org/2536553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp:211:
pendingScript->stopWatchingForLoad();
On 2016/11/28 16:17:59, sof wrote:
> Can this call (effectively) be moved down to where the dispose() now is?

Good catch. I'd like to separate patch for this as I'm not 100% certain if its
possible. We may run a checkpoint + early return path due to it.

[dominicc (has gone to gerrit), 2016-11-29 01:07:22]

lgtm

[yhirano, 2016-11-29 01:29:00]

https://codereview.chromium.org/2536553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/ScriptLoader.cpp (right):

https://codereview.chromium.org/2536553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ScriptLoader.cpp:564:
m_pendingScript->dispose();
Can you tell me why we can call stopWatchingLoad here?

https://codereview.chromium.org/2536553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp (right):

https://codereview.chromium.org/2536553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp:518:
m_parserBlockingScript->dispose();
Can you tell me why we can call stopWatchingLoad here?

[kouhei (in TOK), 2016-11-29 01:52:57]

https://codereview.chromium.org/2536553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/ScriptLoader.cpp (right):

https://codereview.chromium.org/2536553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ScriptLoader.cpp:564:
m_pendingScript->dispose();
On 2016/11/29 01:29:00, yhirano wrote:
> Can you tell me why we can call stopWatchingLoad here?

At this point, we are certain that we have finished the ScriptResource load.
This condition is checked inside PendingScript::getSource call just above this
line:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Pendi...

This means that ScriptLoader::notifyFinished has already called
stopWatchingForLoad, making this a no-op.

https://codereview.chromium.org/2536553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp (right):

https://codereview.chromium.org/2536553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp:518:
m_parserBlockingScript->dispose();
On 2016/11/29 01:29:00, yhirano wrote:
> Can you tell me why we can call stopWatchingLoad here?

This is when we execute inline scripts.
We shouldn't have a network-fetched Resource attached to the script, thus
stopWatchingLoad equiv should be just a no-op.

[commit-bot: I haz the power, 2016-11-29 02:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:38:58]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-11-29 04:44:19]

lgtm

[kouhei (in TOK), 2016-11-29 04:45:39]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2016-11-29 04:45:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 04:49:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480394739770130,
"parent_rev": "0141e19670511c7bff302068c2c40e87099744f0", "commit_rev":
"c01f62cb762aaf97a7b7fa37fb18d62023d666b4"}

[commit-bot: I haz the power, 2016-11-29 04:50:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 04:54:54]

Description was changed from

==========
Simplify: remove PendingScript::releaseElementAndClear

Simplify PendingScript disposal path by removing method releaseElementAndClear.
Callers should use dispose() directly instead of repeating stopWatchingForLoad +
releaseElementAndClear calls.

BUG=None
==========

to

==========
Simplify: remove PendingScript::releaseElementAndClear

Simplify PendingScript disposal path by removing method releaseElementAndClear.
Callers should use dispose() directly instead of repeating stopWatchingForLoad +
releaseElementAndClear calls.

BUG=None

Committed: https://crrev.com/9ec9d9b469c760634b4d0126a2c369f3627ac8e9
Cr-Commit-Position: refs/heads/master@{#434897}
==========

[commit-bot: I haz the power, 2016-11-29 04:54:55]

Patchset 2 (id:??) landed as
https://crrev.com/9ec9d9b469c760634b4d0126a2c369f3627ac8e9
Cr-Commit-Position: refs/heads/master@{#434897}