third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp - Issue 2536553002: Simplify: remove PendingScript::releaseElementAndClear

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

Issue 2536553002: Simplify: remove PendingScript::releaseElementAndClear (Closed)

Patch Set: git cl try Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

index 79aa610af8b5a94f7ffb6286775e4c5fd2e48fe6..31b569854020a6170bd15e6e55e09323245bc5b1 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

@@ -196,8 +196,7 @@ TEST_F(ScriptStreamingTest, CancellingStreaming) {

// Simulate cancelling the network load (e.g., because the user navigated

// away).

EXPECT_FALSE(client->finished());

- getPendingScript()->stopWatchingForLoad();

- getPendingScript()->releaseElementAndClear();

+ getPendingScript()->dispose();

m_pendingScript = nullptr; // This will destroy m_resource.

m_resource = nullptr;