Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 2536553002: Simplify: remove PendingScript::releaseElementAndClear (Closed)
Patch Set: git cl try Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
index 6643e5e70a43bfba96a9c1534a44fe51a0e3c975..ff12ae9cb2411ed959a80ddcef381ef05bf7beb3 100644
--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
@@ -561,8 +561,7 @@ void ScriptLoader::execute() {
DCHECK(m_pendingScript->resource());
bool errorOccurred = false;
ScriptSourceCode source = m_pendingScript->getSource(KURL(), errorOccurred);
- Element* element = m_pendingScript->releaseElementAndClear();
- ALLOW_UNUSED_LOCAL(element);
+ m_pendingScript->dispose();
yhirano 2016/11/29 01:29:00 Can you tell me why we can call stopWatchingLoad h
kouhei (in TOK) 2016/11/29 01:52:57 At this point, we are certain that we have finishe
if (errorOccurred) {
dispatchErrorEvent();
} else if (!m_resource->wasCanceled()) {

Powered by Google App Engine
This is Rietveld 408576698