Simplify: remove PendingScript::releaseElementAndClear

third_party/WebKit/Source/core/dom/ScriptLoader.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 543 matching lines @@
 
   return true;
 }
 
 void ScriptLoader::execute() {
   DCHECK(!m_willBeParserExecuted);
   DCHECK(m_asyncExecType != ScriptRunner::None);
   DCHECK(m_pendingScript->resource());
   bool errorOccurred = false;
   ScriptSourceCode source = m_pendingScript->getSource(KURL(), errorOccurred);
-  Element* element = m_pendingScript->releaseElementAndClear();
-  ALLOW_UNUSED_LOCAL(element);
+  m_pendingScript->dispose();

[yhirano, 2016/11/29 01:29:00]

Can you tell me why we can call stopWatchingLoad here?

[kouhei (in TOK), 2016/11/29 01:52:57]

At this point, we are certain that we have finished the ScriptResource load.
This condition is checked inside PendingScript::getSource call just above this
line:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Pendi...

This means that ScriptLoader::notifyFinished has already called
stopWatchingForLoad, making this a no-op.

   if (errorOccurred) {
     dispatchErrorEvent();
   } else if (!m_resource->wasCanceled()) {
     if (executeScript(source))
       dispatchLoadEvent();
     else
       dispatchErrorEvent();
   }
   m_resource = nullptr;
 }
@@ skipping 71 matching lines @@
   if (isHTMLScriptLoader(element))
     return toHTMLScriptElement(element)->loader();
 
   if (isSVGScriptLoader(element))
     return toSVGScriptElement(element)->loader();
 
   return 0;
 }
 
 }  // namespace blink