Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2534873004: Avoid unchecked casts in UA shadow DOM. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
hayato, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, Mikhail, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid unchecked casts in UA shadow DOM. If we have a way to leak UA shadow DOM to web authors or Chrome extension authors, these unchecked casts would be dangerous. This CL introduces toFooTypeOrDie() helpers, and apply it to UA shadow DOM. BUG=668970 Committed: https://crrev.com/2ce7841faa0fcfb4bff02b808745a9399a1c0603 Cr-Commit-Position: refs/heads/master@{#434899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -44 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp View 1 chunk +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 1 chunk +47 lines, -21 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tkent
yosin@, or hayato@, would you review this please?
4 years ago (2016-11-29 03:39:22 UTC) #5
hayato
lgtm
4 years ago (2016-11-29 04:13:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534873004/1
4 years ago (2016-11-29 05:07:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 05:12:16 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-29 05:16:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ce7841faa0fcfb4bff02b808745a9399a1c0603
Cr-Commit-Position: refs/heads/master@{#434899}

Powered by Google App Engine
This is Rietveld 408576698