third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp - Issue 2534873004: Avoid unchecked casts in UA shadow DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

Issue 2534873004: Avoid unchecked casts in UA shadow DOM. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp b/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

index 5a34cbf08bc6c35a3bda87f430fd84fe50aa0e87..e5e515e5bfe3ebddb838cbbdb143cd0ef4cfb03a 100644

--- a/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

@@ -112,9 +112,9 @@ Element* HTMLDetailsElement::findMainSummary() const {

return summary;

HTMLContentElement* content =

- toHTMLContentElement(userAgentShadowRoot()->firstChild());

+ toHTMLContentElementOrDie(userAgentShadowRoot()->firstChild());

DCHECK(content->firstChild());

- DCHECK(isHTMLSummaryElement(*content->firstChild()));

+ CHECK(isHTMLSummaryElement(*content->firstChild()));

return toElement(content->firstChild());

}