third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp - Issue 2534873004: Avoid unchecked casts in UA shadow DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

Issue 2534873004: Avoid unchecked casts in UA shadow DOM. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp b/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

index 99f7960b16e25a8fd892b5448e6d9d13077d7009..9915a00bfd83b934e1536ad24c2a4df800ae3553 100644

--- a/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp

@@ -62,7 +62,7 @@ void BaseButtonInputType::createShadowSubtree() {

}

void BaseButtonInputType::valueAttributeChanged() {

- toText(element().userAgentShadowRoot()->firstChild())

+ toTextOrDie(element().userAgentShadowRoot()->firstChild())

->setData(displayValue());

}