third_party/WebKit/Source/core/html/forms/ColorInputType.cpp - Issue 2534873004: Avoid unchecked casts in UA shadow DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

Issue 2534873004: Avoid unchecked casts in UA shadow DOM. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

index 3bd2c9bf0f1964b7d2c0d13c59f08e6c2fd3f139..0f3b9e24264f34840957b4e36e824721e2004f13 100644

--- a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

@@ -218,7 +218,8 @@ void ColorInputType::updateView() {

HTMLElement* ColorInputType::shadowColorSwatch() const {

ShadowRoot* shadow = element().userAgentShadowRoot();

- return shadow ? toHTMLElement(shadow->firstChild()->firstChild()) : 0;

+ return shadow ? toHTMLElementOrDie(shadow->firstChild()->firstChild())

+ : nullptr;

}

Element& ColorInputType::ownerElement() const {