Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2533483002: [DevTools] Typed events and event listeners. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
caseq, alph, lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Typed events and event listeners. BUG=none

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -150 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator.html View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-rename-mapped-file.html View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/common/ObjectBase.js View 1 chunk +170 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/common/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js View 4 chunks +16 lines, -6 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js View 4 chunks +14 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js View 6 chunks +37 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 3 chunks +15 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 3 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js View 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WorkspaceMappingTip.js View 1 chunk +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/DropDownMenu.js View 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
dgozman
Hi, What do you think about this? It's fully compiled, and is not very verbose. ...
4 years ago (2016-11-24 22:45:27 UTC) #2
lushnikov
We can have events namespace which comes handy: Resources.DOMStorageModel.Events = { DOMStorageAdded: class { /** ...
4 years ago (2016-11-28 19:01:43 UTC) #3
pfeldman
4 years ago (2016-11-28 19:30:39 UTC) #4
https://codereview.chromium.org/2533483002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/common/ObjectBase.js (right):

https://codereview.chromium.org/2533483002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/common/ObjectBase.js:38: * @param
{function(!T)} listener
I think this exact thing did not work for me in Runtime.js's instance back in
the day.

https://codereview.chromium.org/2533483002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2533483002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:230:
Persistence.Persistence.BindingChangedEvent = class {
"FooEvent" should inherit from "Event" and have properties such as "source",
"target", etc.

Powered by Google App Engine
This is Rietveld 408576698