Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2530893003: [DevTools] Remove support for string event types. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove support for string event types. BUG=none Committed: https://crrev.com/270359922e4eaa0126751d32d47a769150ac1ff1 Cr-Commit-Position: refs/heads/master@{#434774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/devtools/front_end/common/Object.js View 9 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
dgozman
Could you please take a look?
4 years ago (2016-11-24 21:13:36 UTC) #9
alph
lgtm
4 years ago (2016-11-28 17:51:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530893003/1
4 years ago (2016-11-28 17:51:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 23:30:59 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-28 23:32:59 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/270359922e4eaa0126751d32d47a769150ac1ff1
Cr-Commit-Position: refs/heads/master@{#434774}

Powered by Google App Engine
This is Rietveld 408576698